From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 511B4C433F5 for ; Tue, 12 Apr 2022 16:55:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B396F6B0072; Tue, 12 Apr 2022 12:55:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE9DE6B0073; Tue, 12 Apr 2022 12:55:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9AF446B0074; Tue, 12 Apr 2022 12:55:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0009.hostedemail.com [216.40.44.9]) by kanga.kvack.org (Postfix) with ESMTP id 8920B6B0072 for ; Tue, 12 Apr 2022 12:55:48 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 384211837E1A7 for ; Tue, 12 Apr 2022 16:55:48 +0000 (UTC) X-FDA: 79348828776.21.67D5B49 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 98F00C000D for ; Tue, 12 Apr 2022 16:55:47 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E12F2618CF; Tue, 12 Apr 2022 16:55:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB210C385A1; Tue, 12 Apr 2022 16:55:43 +0000 (UTC) Date: Tue, 12 Apr 2022 17:55:40 +0100 From: Catalin Marinas To: Vlastimil Babka Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Ohhoon Kwon , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , JaeSang Yoo , Wonhyuk Yang , Jiyoup Kim , Donghyeok Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/slab_common: move dma-kmalloc caches creation into new_kmalloc_cache() Message-ID: References: <20220410162511.656541-1-ohkwon1043@gmail.com> <9b02d27a-b4c0-acfa-dc0b-ac4912c1d3e6@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9b02d27a-b4c0-acfa-dc0b-ac4912c1d3e6@suse.cz> Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf28.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 98F00C000D X-Stat-Signature: trdacncjuz45c93m39c1a1zjsyc86xnm X-HE-Tag: 1649782547-429563 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 11, 2022 at 05:31:51PM +0200, Vlastimil Babka wrote: > On 4/11/22 13:07, Hyeonggon Yoo wrote: > > On Mon, Apr 11, 2022 at 01:25:11AM +0900, Ohhoon Kwon wrote: > >> @@ -898,20 +900,6 @@ void __init create_kmalloc_caches(slab_flags_t flags) > >> > >> /* Kmalloc array is now usable */ > >> slab_state = UP; > >> - > >> -#ifdef CONFIG_ZONE_DMA > >> - for (i = 0; i <= KMALLOC_SHIFT_HIGH; i++) { > >> - struct kmem_cache *s = kmalloc_caches[KMALLOC_NORMAL][i]; > >> - > >> - if (s) { > >> - kmalloc_caches[KMALLOC_DMA][i] = create_kmalloc_cache( > >> - kmalloc_info[i].name[KMALLOC_DMA], > >> - kmalloc_info[i].size, > >> - SLAB_CACHE_DMA | flags, 0, > >> - kmalloc_info[i].size); > >> - } > >> - } > >> -#endif > >> } > >> #endif /* !CONFIG_SLOB */ > > > > Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > Thanks. > Added to: > https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git/log/?h=for-5.19/refactor > > > BTW this patch may conflict with [1] (not merged yet) > > > > [1] https://lore.kernel.org/linux-mm/20220405135758.774016-9-catalin.marinas@arm.com/ > > FYI Catalin, might want to base v2 on the above once the crypto side is > solved. At cursory look it shouldn't be a significant conflict. Thanks for the heads-up. I did wonder why this was a separate loop. -- Catalin