From: Catalin Marinas <catalin.marinas@arm.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>,
Ohhoon Kwon <ohkwon1043@gmail.com>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
JaeSang Yoo <jsyoo5b@gmail.com>,
Wonhyuk Yang <vvghjk1234@gmail.com>,
Jiyoup Kim <lakroforce@gmail.com>,
Donghyeok Kim <dthex5d@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/slab_common: move dma-kmalloc caches creation into new_kmalloc_cache()
Date: Tue, 12 Apr 2022 17:55:40 +0100 [thread overview]
Message-ID: <YlWvDBtW1pVY+H8z@arm.com> (raw)
In-Reply-To: <9b02d27a-b4c0-acfa-dc0b-ac4912c1d3e6@suse.cz>
On Mon, Apr 11, 2022 at 05:31:51PM +0200, Vlastimil Babka wrote:
> On 4/11/22 13:07, Hyeonggon Yoo wrote:
> > On Mon, Apr 11, 2022 at 01:25:11AM +0900, Ohhoon Kwon wrote:
> >> @@ -898,20 +900,6 @@ void __init create_kmalloc_caches(slab_flags_t flags)
> >>
> >> /* Kmalloc array is now usable */
> >> slab_state = UP;
> >> -
> >> -#ifdef CONFIG_ZONE_DMA
> >> - for (i = 0; i <= KMALLOC_SHIFT_HIGH; i++) {
> >> - struct kmem_cache *s = kmalloc_caches[KMALLOC_NORMAL][i];
> >> -
> >> - if (s) {
> >> - kmalloc_caches[KMALLOC_DMA][i] = create_kmalloc_cache(
> >> - kmalloc_info[i].name[KMALLOC_DMA],
> >> - kmalloc_info[i].size,
> >> - SLAB_CACHE_DMA | flags, 0,
> >> - kmalloc_info[i].size);
> >> - }
> >> - }
> >> -#endif
> >> }
> >> #endif /* !CONFIG_SLOB */
> >
> > Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
>
> Thanks.
> Added to:
> https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git/log/?h=for-5.19/refactor
>
> > BTW this patch may conflict with [1] (not merged yet)
> >
> > [1] https://lore.kernel.org/linux-mm/20220405135758.774016-9-catalin.marinas@arm.com/
>
> FYI Catalin, might want to base v2 on the above once the crypto side is
> solved. At cursory look it shouldn't be a significant conflict.
Thanks for the heads-up. I did wonder why this was a separate loop.
--
Catalin
next prev parent reply other threads:[~2022-04-12 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220410162511.656541-1-ohkwon1043@gmail.com>
2022-04-11 11:07 ` Hyeonggon Yoo
2022-04-11 15:31 ` Vlastimil Babka
2022-04-12 16:55 ` Catalin Marinas [this message]
2022-04-12 23:38 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlWvDBtW1pVY+H8z@arm.com \
--to=catalin.marinas@arm.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dthex5d@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jsyoo5b@gmail.com \
--cc=lakroforce@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ohkwon1043@gmail.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
--cc=vvghjk1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox