Re: [PATCH 5.15 000/277] 5.15.34-rc1 review

Re: [PATCH 5.15 000/277] 5.15.34-rc1 review

[Naresh Kamboju]

On Tue, 12 Apr 2022 at 12:11, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 5.15.34 release.
> There are 277 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 14 Apr 2022 06:28:59 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
>         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.34-rc1.gz
> or in the git tree and branch at:
>         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h


On linux stable-rc 5.15 x86 and i386 builds failed due to below error [1]
with config [2].

The finding is when kunit config is enabled the builds pass.
CONFIG_KUNIT=y

But with CONFIG_KUNIT not set the builds failed.

x86_64-linux-gnu-ld: mm/kfence/core.o: in function `__kfence_alloc':
core.c:(.text+0x901): undefined reference to `filter_irq_stacks'
make[1]: *** [/builds/linux/Makefile:1183: vmlinux] Error 1

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

I see these three commits, I will bisect and get back to you

2f222c87ceb4 kfence: limit currently covered allocations when pool nearly full
e25487912879 kfence: move saving stack trace of allocations into
__kfence_alloc()
d99355395380 kfence: count unexpectedly skipped allocations


--
Linaro LKFT
https://lkft.linaro.org

[1] https://builds.tuxbuild.com/27h6Ztu4T35pY178Xg8EyAj7gIW/
[2] https://builds.tuxbuild.com/27h6Ztu4T35pY178Xg8EyAj7gIW/config

Re: [PATCH 5.15 000/277] 5.15.34-rc1 review

[Marco Elver]

On Tue, 12 Apr 2022 at 16:16, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> On Tue, 12 Apr 2022 at 12:11, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > This is the start of the stable review cycle for the 5.15.34 release.
> > There are 277 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 14 Apr 2022 06:28:59 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> >         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.34-rc1.gz
> > or in the git tree and branch at:
> >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
>
> On linux stable-rc 5.15 x86 and i386 builds failed due to below error [1]
> with config [2].
>
> The finding is when kunit config is enabled the builds pass.
> CONFIG_KUNIT=y
>
> But with CONFIG_KUNIT not set the builds failed.
>
> x86_64-linux-gnu-ld: mm/kfence/core.o: in function `__kfence_alloc':
> core.c:(.text+0x901): undefined reference to `filter_irq_stacks'
> make[1]: *** [/builds/linux/Makefile:1183: vmlinux] Error 1
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> I see these three commits, I will bisect and get back to you
>
> 2f222c87ceb4 kfence: limit currently covered allocations when pool nearly full
> e25487912879 kfence: move saving stack trace of allocations into
> __kfence_alloc()
> d99355395380 kfence: count unexpectedly skipped allocations

My guess is that this commit is missing:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f39f21b3ddc7fc0f87eb6dc75ddc81b5bbfb7672

Thanks,
-- Marco

Re: [PATCH 5.15 000/277] 5.15.34-rc1 review

[Naresh Kamboju]

Hi Marco

On Tue, 12 Apr 2022 at 20:32, Marco Elver <elver@google.com> wrote:
>
> On Tue, 12 Apr 2022 at 16:16, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> >
> > On Tue, 12 Apr 2022 at 12:11, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > This is the start of the stable review cycle for the 5.15.34 release.
> > > There are 277 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Thu, 14 Apr 2022 06:28:59 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > >         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.34-rc1.gz
> > > or in the git tree and branch at:
> > >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> >
> > On linux stable-rc 5.15 x86 and i386 builds failed due to below error [1]
> > with config [2].
> >
> > The finding is when kunit config is enabled the builds pass.
> > CONFIG_KUNIT=y
> >
> > But with CONFIG_KUNIT not set the builds failed.
> >
> > x86_64-linux-gnu-ld: mm/kfence/core.o: in function `__kfence_alloc':
> > core.c:(.text+0x901): undefined reference to `filter_irq_stacks'
> > make[1]: *** [/builds/linux/Makefile:1183: vmlinux] Error 1
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> >
> > I see these three commits, I will bisect and get back to you
> >
> > 2f222c87ceb4 kfence: limit currently covered allocations when pool nearly full
> > e25487912879 kfence: move saving stack trace of allocations into
> > __kfence_alloc()
> > d99355395380 kfence: count unexpectedly skipped allocations
>
> My guess is that this commit is missing:

This patch is missing Fixes: tag.

> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f39f21b3ddc7fc0f87eb6dc75ddc81b5bbfb7672

For your information, I have reverted the below commit and build pass.

kfence: limit currently covered allocations when pool nearly full

[ Upstream commit 08f6b10630f284755087f58aa393402e15b92977 ]

- Naresh

> Thanks,
> -- Marco

Re: [PATCH 5.15 000/277] 5.15.34-rc1 review

[Marco Elver]

On Tue, 12 Apr 2022 at 17:44, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> Hi Marco
>
> On Tue, 12 Apr 2022 at 20:32, Marco Elver <elver@google.com> wrote:
> >
> > On Tue, 12 Apr 2022 at 16:16, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> > >
> > > On Tue, 12 Apr 2022 at 12:11, Greg Kroah-Hartman
> > > <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > This is the start of the stable review cycle for the 5.15.34 release.
> > > > There are 277 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > >
> > > > Responses should be made by Thu, 14 Apr 2022 06:28:59 +0000.
> > > > Anything received after that time might be too late.
> > > >
> > > > The whole patch series can be found in one patch at:
> > > >         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.34-rc1.gz
> > > > or in the git tree and branch at:
> > > >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> > > > and the diffstat can be found below.
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
> > >
> > >
> > > On linux stable-rc 5.15 x86 and i386 builds failed due to below error [1]
> > > with config [2].
> > >
> > > The finding is when kunit config is enabled the builds pass.
> > > CONFIG_KUNIT=y
> > >
> > > But with CONFIG_KUNIT not set the builds failed.
> > >
> > > x86_64-linux-gnu-ld: mm/kfence/core.o: in function `__kfence_alloc':
> > > core.c:(.text+0x901): undefined reference to `filter_irq_stacks'
> > > make[1]: *** [/builds/linux/Makefile:1183: vmlinux] Error 1
> > >
> > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > >
> > > I see these three commits, I will bisect and get back to you
> > >
> > > 2f222c87ceb4 kfence: limit currently covered allocations when pool nearly full
> > > e25487912879 kfence: move saving stack trace of allocations into
> > > __kfence_alloc()
> > > d99355395380 kfence: count unexpectedly skipped allocations
> >
> > My guess is that this commit is missing:
>
> This patch is missing Fixes: tag.

No it's not - it was patch 1/N in this series:
https://lore.kernel.org/all/20210923104803.2620285-1-elver@google.com/

> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f39f21b3ddc7fc0f87eb6dc75ddc81b5bbfb7672

Re: [PATCH 5.15 000/277] 5.15.34-rc1 review

[Greg Kroah-Hartman]

On Tue, Apr 12, 2022 at 09:13:59PM +0530, Naresh Kamboju wrote:
> Hi Marco
> 
> On Tue, 12 Apr 2022 at 20:32, Marco Elver <elver@google.com> wrote:
> >
> > On Tue, 12 Apr 2022 at 16:16, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> > >
> > > On Tue, 12 Apr 2022 at 12:11, Greg Kroah-Hartman
> > > <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > This is the start of the stable review cycle for the 5.15.34 release.
> > > > There are 277 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > >
> > > > Responses should be made by Thu, 14 Apr 2022 06:28:59 +0000.
> > > > Anything received after that time might be too late.
> > > >
> > > > The whole patch series can be found in one patch at:
> > > >         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.34-rc1.gz
> > > > or in the git tree and branch at:
> > > >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> > > > and the diffstat can be found below.
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
> > >
> > >
> > > On linux stable-rc 5.15 x86 and i386 builds failed due to below error [1]
> > > with config [2].
> > >
> > > The finding is when kunit config is enabled the builds pass.
> > > CONFIG_KUNIT=y
> > >
> > > But with CONFIG_KUNIT not set the builds failed.
> > >
> > > x86_64-linux-gnu-ld: mm/kfence/core.o: in function `__kfence_alloc':
> > > core.c:(.text+0x901): undefined reference to `filter_irq_stacks'
> > > make[1]: *** [/builds/linux/Makefile:1183: vmlinux] Error 1
> > >
> > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > >
> > > I see these three commits, I will bisect and get back to you
> > >
> > > 2f222c87ceb4 kfence: limit currently covered allocations when pool nearly full
> > > e25487912879 kfence: move saving stack trace of allocations into
> > > __kfence_alloc()
> > > d99355395380 kfence: count unexpectedly skipped allocations
> >
> > My guess is that this commit is missing:
> 
> This patch is missing Fixes: tag.
> 
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f39f21b3ddc7fc0f87eb6dc75ddc81b5bbfb7672
> 
> For your information, I have reverted the below commit and build pass.
> 
> kfence: limit currently covered allocations when pool nearly full
> 
> [ Upstream commit 08f6b10630f284755087f58aa393402e15b92977 ]

I've added the above commit, does that fix the issue?

Hm, I can test that here, let me try it...

greg k-h

Re: [PATCH 5.15 000/277] 5.15.34-rc1 review

[Greg Kroah-Hartman]

On Tue, Apr 12, 2022 at 06:43:15PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 12, 2022 at 09:13:59PM +0530, Naresh Kamboju wrote:
> > Hi Marco
> > 
> > On Tue, 12 Apr 2022 at 20:32, Marco Elver <elver@google.com> wrote:
> > >
> > > On Tue, 12 Apr 2022 at 16:16, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> > > >
> > > > On Tue, 12 Apr 2022 at 12:11, Greg Kroah-Hartman
> > > > <gregkh@linuxfoundation.org> wrote:
> > > > >
> > > > > This is the start of the stable review cycle for the 5.15.34 release.
> > > > > There are 277 patches in this series, all will be posted as a response
> > > > > to this one.  If anyone has any issues with these being applied, please
> > > > > let me know.
> > > > >
> > > > > Responses should be made by Thu, 14 Apr 2022 06:28:59 +0000.
> > > > > Anything received after that time might be too late.
> > > > >
> > > > > The whole patch series can be found in one patch at:
> > > > >         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.34-rc1.gz
> > > > > or in the git tree and branch at:
> > > > >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> > > > > and the diffstat can be found below.
> > > > >
> > > > > thanks,
> > > > >
> > > > > greg k-h
> > > >
> > > >
> > > > On linux stable-rc 5.15 x86 and i386 builds failed due to below error [1]
> > > > with config [2].
> > > >
> > > > The finding is when kunit config is enabled the builds pass.
> > > > CONFIG_KUNIT=y
> > > >
> > > > But with CONFIG_KUNIT not set the builds failed.
> > > >
> > > > x86_64-linux-gnu-ld: mm/kfence/core.o: in function `__kfence_alloc':
> > > > core.c:(.text+0x901): undefined reference to `filter_irq_stacks'
> > > > make[1]: *** [/builds/linux/Makefile:1183: vmlinux] Error 1
> > > >
> > > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > > >
> > > > I see these three commits, I will bisect and get back to you
> > > >
> > > > 2f222c87ceb4 kfence: limit currently covered allocations when pool nearly full
> > > > e25487912879 kfence: move saving stack trace of allocations into
> > > > __kfence_alloc()
> > > > d99355395380 kfence: count unexpectedly skipped allocations
> > >
> > > My guess is that this commit is missing:
> > 
> > This patch is missing Fixes: tag.
> > 
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f39f21b3ddc7fc0f87eb6dc75ddc81b5bbfb7672
> > 
> > For your information, I have reverted the below commit and build pass.
> > 
> > kfence: limit currently covered allocations when pool nearly full
> > 
> > [ Upstream commit 08f6b10630f284755087f58aa393402e15b92977 ]
> 
> I've added the above commit, does that fix the issue?
> 
> Hm, I can test that here, let me try it...

I can't duplicate the failure here with my config, let me try yours...

Re: [PATCH 5.15 000/277] 5.15.34-rc1 review

[Greg Kroah-Hartman]

On Tue, Apr 12, 2022 at 07:23:10PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 12, 2022 at 06:43:15PM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Apr 12, 2022 at 09:13:59PM +0530, Naresh Kamboju wrote:
> > > Hi Marco
> > > 
> > > On Tue, 12 Apr 2022 at 20:32, Marco Elver <elver@google.com> wrote:
> > > >
> > > > On Tue, 12 Apr 2022 at 16:16, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> > > > >
> > > > > On Tue, 12 Apr 2022 at 12:11, Greg Kroah-Hartman
> > > > > <gregkh@linuxfoundation.org> wrote:
> > > > > >
> > > > > > This is the start of the stable review cycle for the 5.15.34 release.
> > > > > > There are 277 patches in this series, all will be posted as a response
> > > > > > to this one.  If anyone has any issues with these being applied, please
> > > > > > let me know.
> > > > > >
> > > > > > Responses should be made by Thu, 14 Apr 2022 06:28:59 +0000.
> > > > > > Anything received after that time might be too late.
> > > > > >
> > > > > > The whole patch series can be found in one patch at:
> > > > > >         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.34-rc1.gz
> > > > > > or in the git tree and branch at:
> > > > > >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> > > > > > and the diffstat can be found below.
> > > > > >
> > > > > > thanks,
> > > > > >
> > > > > > greg k-h
> > > > >
> > > > >
> > > > > On linux stable-rc 5.15 x86 and i386 builds failed due to below error [1]
> > > > > with config [2].
> > > > >
> > > > > The finding is when kunit config is enabled the builds pass.
> > > > > CONFIG_KUNIT=y
> > > > >
> > > > > But with CONFIG_KUNIT not set the builds failed.
> > > > >
> > > > > x86_64-linux-gnu-ld: mm/kfence/core.o: in function `__kfence_alloc':
> > > > > core.c:(.text+0x901): undefined reference to `filter_irq_stacks'
> > > > > make[1]: *** [/builds/linux/Makefile:1183: vmlinux] Error 1
> > > > >
> > > > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > > > >
> > > > > I see these three commits, I will bisect and get back to you
> > > > >
> > > > > 2f222c87ceb4 kfence: limit currently covered allocations when pool nearly full
> > > > > e25487912879 kfence: move saving stack trace of allocations into
> > > > > __kfence_alloc()
> > > > > d99355395380 kfence: count unexpectedly skipped allocations
> > > >
> > > > My guess is that this commit is missing:
> > > 
> > > This patch is missing Fixes: tag.
> > > 
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f39f21b3ddc7fc0f87eb6dc75ddc81b5bbfb7672
> > > 
> > > For your information, I have reverted the below commit and build pass.
> > > 
> > > kfence: limit currently covered allocations when pool nearly full
> > > 
> > > [ Upstream commit 08f6b10630f284755087f58aa393402e15b92977 ]
> > 
> > I've added the above commit, does that fix the issue?
> > 
> > Hm, I can test that here, let me try it...
> 
> I can't duplicate the failure here with my config, let me try yours...

Yes, with your config before it fails, after I added the commit it
works.  I'll push out a -rc2 soon with that added.

thanks,

greg k-h