From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7B00C433EF for ; Tue, 12 Apr 2022 04:20:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C41046B0071; Tue, 12 Apr 2022 00:20:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF0726B0073; Tue, 12 Apr 2022 00:20:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB8926B0074; Tue, 12 Apr 2022 00:20:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 9D06A6B0071 for ; Tue, 12 Apr 2022 00:20:07 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7A45561BAA for ; Tue, 12 Apr 2022 04:20:07 +0000 (UTC) X-FDA: 79346924454.10.868BE57 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 0F6F52000A for ; Tue, 12 Apr 2022 04:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KkMg8Uf8LW6cbwskVM3FacACcaEeYcQo6r7APr6POlA=; b=3cY8tpKNT1BaSTaCkKVAoxndqi AwpMQHnIuH73A0J9X6Ayv2Q4DR2b1Oa0JfpBKLMye+UyOL6u28Usi5+gXgQsPzggXpDFvKm7kquqH A0bCtDj0OdYT2nXsIvvYggaH1Y+DbBTUMlZfpKvSB0VQshU0QITJvj0fxFL7p3J/Yqp9KOlGgM9ya 7vPplIE+BAjgkwHENswnO7L8bvdMT2nyAEUiC7OCvYR7o3EYpJIdL3xoNBfVaYm6JSDDwOAJXqpCU Om9an+IhivYEVSG+o/55uA1waNZ3TDPplzBB5y4NtKhNl9fR5SuCubQY6mv70PiCB2HsJDa7/CcME /QY/bDLg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ne80b-00BWBI-2P; Tue, 12 Apr 2022 04:20:05 +0000 Date: Mon, 11 Apr 2022 21:20:05 -0700 From: Christoph Hellwig To: Song Liu Cc: bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, akpm@linux-foundation.org, rick.p.edgecombe@intel.com, hch@infradead.org, imbrenda@linux.ibm.com, mcgrof@kernel.org Subject: Re: [PATCH v2 bpf 2/3] module: introduce module_alloc_huge Message-ID: References: <20220411233549.740157-1-song@kernel.org> <20220411233549.740157-3-song@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220411233549.740157-3-song@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: 3bgg767qwuabzsamai9d38x67h5hh58g Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=3cY8tpKN; dmarc=none; spf=none (imf03.hostedemail.com: domain of BATV+ac3e28a1d77c94e338e3+6806+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+ac3e28a1d77c94e338e3+6806+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 0F6F52000A X-HE-Tag: 1649737206-187322 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 11, 2022 at 04:35:47PM -0700, Song Liu wrote: > Introduce module_alloc_huge, which allocates huge page backed memory in > module memory space. The primary user of this memory is bpf_prog_pack > (multiple BPF programs sharing a huge page). I kow I lead you downthis road first, but I wonder if we just want to pass a flag to module_alloc instead. This avoids duplicating all the arch overrides.