From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23B16C433EF for ; Mon, 11 Apr 2022 14:02:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 901018D0001; Mon, 11 Apr 2022 10:02:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B0086B0075; Mon, 11 Apr 2022 10:02:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A03F8D0001; Mon, 11 Apr 2022 10:02:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 6DF056B0074 for ; Mon, 11 Apr 2022 10:02:20 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 34DBD61CF4 for ; Mon, 11 Apr 2022 14:02:20 +0000 (UTC) X-FDA: 79344762840.06.857B578 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id B22A3A0015 for ; Mon, 11 Apr 2022 14:02:19 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 28B5B61052; Mon, 11 Apr 2022 14:02:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAE8AC385A3; Mon, 11 Apr 2022 14:02:16 +0000 (UTC) Date: Mon, 11 Apr 2022 15:02:13 +0100 From: Catalin Marinas To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/10] mm/slab: Decouple ARCH_KMALLOC_MINALIGN from ARCH_DMA_MINALIGN Message-ID: References: <20220405135758.774016-1-catalin.marinas@arm.com> <20220405135758.774016-2-catalin.marinas@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf25.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org X-Stat-Signature: 1hiue5dsax6coa7y6b3pcmd79hmijsw3 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B22A3A0015 X-HE-Tag: 1649685739-496098 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 11, 2022 at 07:37:01PM +0900, Hyeonggon Yoo wrote: > On Tue, Apr 05, 2022 at 02:57:49PM +0100, Catalin Marinas wrote: > > In preparation for supporting a dynamic kmalloc() minimum alignment, > > allow architectures to define ARCH_KMALLOC_MINALIGN independently of > > ARCH_DMA_MINALIGN. In addition, always define ARCH_DMA_MINALIGN even if > > an architecture does not override it. > > > > After this patch, ARCH_DMA_MINALIGN is expected to be used in static > > alignment annotations and defined by an architecture to be the maximum > > alignment for all supported configurations/SoCs in a single Image. > > ARCH_KMALLOC_MINALIGN, if different, is the minimum alignment guaranteed > > by kmalloc(). > > > > Signed-off-by: Catalin Marinas > > Cc: Andrew Morton [...] > Sorry for the noise I made due to misunderstanding :) > Now this patch looks good to me and I think it's worth adding. > > Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > and works fine with SLAB/SLOB/SLUB on my arm64 machine. > > Tested-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Thanks for the review and test. We still need to solve the potential crypto issues raised by Herbert before making the change. -- Catalin