From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24CCCC433F5 for ; Sun, 10 Apr 2022 07:14:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6708F6B0071; Sun, 10 Apr 2022 03:14:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 603716B0073; Sun, 10 Apr 2022 03:14:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4996C6B0074; Sun, 10 Apr 2022 03:14:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by kanga.kvack.org (Postfix) with ESMTP id 381206B0071 for ; Sun, 10 Apr 2022 03:14:50 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DD6181837E009 for ; Sun, 10 Apr 2022 07:14:49 +0000 (UTC) X-FDA: 79340107098.25.860C787 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf02.hostedemail.com (Postfix) with ESMTP id 6E6E780008 for ; Sun, 10 Apr 2022 07:14:49 +0000 (UTC) Received: by mail-pl1-f174.google.com with SMTP id n18so11403283plg.5 for ; Sun, 10 Apr 2022 00:14:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PMY5eIllAtYW0O4Krr8r6TdMFoC/4GNbntYNUsV7TDM=; b=pmJnpsJ5BKsfrji2xj06XksVesUPMK0FhCQ9OlttXfXl9J/RuqkX01pkBZcbhsB5IQ ICh+EVF8SoUt1+0bKuDFGxo5IrH6BTyRJ0Rmguz/fW5gjmsIaFvPV/TGuEK3k8Uv1Civ xO1W4AnOeFWBR/JOoL+RWSY7DJMRniBOAl+qD8zEEUfegepBvP0oDAc1uXJ2WabrAOg7 MropX/Jm3slB7HpWLL+TELBcfqYkzOJ7cTjIXwtcfxi1SWDufax+fPwfgTH/cAUJjrer JTC3NZ5/G0m2cZx3X2JdT7HV9mQpLnFUhIcN0mv7r5VcQIfGrH4RVHFTfiyH5Q1OPpY0 RAMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PMY5eIllAtYW0O4Krr8r6TdMFoC/4GNbntYNUsV7TDM=; b=8IaKPm5DionFL7w/w+a/0zJ5AuJlfHSeuREBfFsT6ZtrOJ3KQJKHMJ6f3lAasKGgpG PE/uSoiDaSV3xY16K4a8mulMKIHTTdablqui+9n0DQ58/clve/cy2KlLyJTAGkZxq7rU zdA5AfMzCxdWg7eQrUPBZPdYGuDPasMXi2G4JopH3n8P4E0XN7oOlfe0R3aAer7GfVbS hA/mZdymM0LcGELCF8Mt6pUPtViQCG2rPrfa44gvau2OkmarH9pkOCy3zSAhNQEjQGlL +s/w+1yQrVqg94cqNSz8ULGmt5c5dMKG7hggShfRhc8M6WIhLanHdmgQSmpYye8pWsrm /5dA== X-Gm-Message-State: AOAM530NhsXomDurQS8bMRs+7Ka1m7FeWyaBOi9k3sVYotXafmhtzEDX Ye87QWElVuF+YqhTNDDBvL8= X-Google-Smtp-Source: ABdhPJzT2Js1kF46f/1gtMncEUNMETja4yVeubZOnQDIW0iO59NQE/+UrLiSGfVndfjTXq8eGEn4aA== X-Received: by 2002:a17:902:7447:b0:158:2662:b8e2 with SMTP id e7-20020a170902744700b001582662b8e2mr9795761plt.54.1649574888369; Sun, 10 Apr 2022 00:14:48 -0700 (PDT) Received: from hyeyoo ([114.29.24.243]) by smtp.gmail.com with ESMTPSA id w123-20020a623081000000b005056a4d71e3sm10359056pfw.77.2022.04.10.00.14.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Apr 2022 00:14:47 -0700 (PDT) Date: Sun, 10 Apr 2022 16:14:38 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: JaeSang Yoo Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Ohhoon Kwon , Wonhyuk Yang , Jiyoup Kim , Donghyeok Kim , JaeSang Yoo , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/slub: remove meaningless node check in ___slab_alloc() Message-ID: References: <20220409144239.2649257-1-jsyoo5b@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220409144239.2649257-1-jsyoo5b@gmail.com> Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pmJnpsJ5; spf=pass (imf02.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: ri4rp3w1onh3yd1nsje6o9gxxzfuf9wm X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6E6E780008 X-HE-Tag: 1649574889-26575 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 09, 2022 at 11:42:39PM +0900, JaeSang Yoo wrote: > node_match() with node=NUMA_NO_NODE always returns 1. > Duplicate check by goto statement is meaningless. Remove it. Yeah, I think node = NUMA_NO_NODE here is to remove constraints when later calling get_partial_node() or new_slab(). So no further check is required. > > Signed-off-by: JaeSang Yoo > --- > mm/slub.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 9fe000fd19ca..a65e282b8238 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2913,7 +2913,6 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node, > */ > if (!node_isset(node, slab_nodes)) { > node = NUMA_NO_NODE; > - goto redo; > } else { > stat(s, ALLOC_NODE_MISMATCH); > goto deactivate_slab; > -- > 2.25.1 Looks good to me. Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Thanks! > > -- Thanks, Hyeonggon