From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51A05C433EF for ; Sat, 9 Apr 2022 07:53:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0EC86B0071; Sat, 9 Apr 2022 03:53:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CBDD36B0073; Sat, 9 Apr 2022 03:53:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B851A6B0074; Sat, 9 Apr 2022 03:53:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id A6D676B0071 for ; Sat, 9 Apr 2022 03:53:32 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 742BE1214FF for ; Sat, 9 Apr 2022 07:53:32 +0000 (UTC) X-FDA: 79336575864.01.B75B598 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 6EBED100002 for ; Sat, 9 Apr 2022 07:53:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RdaGnqMln3670/kDQ7mKAMFJwaZLOEULPAbgvLVVG7U=; b=biNBw+AmPhGVWsLvNIg7LdLyPE Wc63D/ma3GbzIZqb0n5ZnVGBFo1bdg4BwXlt2nEq4GWfm0+AH0bdQ+OLovrDo/yizqEkE0eMZ28Qd W7hGJlAA5dknkANJSCSzuO+p1Hf3i+RGfBKpgCnRuF3RSgKJjA+P1xdMwSdX+8Al6+iRLqPFff4Oh ybI8THGQLShPPXH+pBPD1jVUqkAawRrDup/5UCYrv1Y1VIzm3zdvEg0KfYMDUdAh8oF63XK3/+XYU Dxr6c7fUYTuUGG6++JPc6AsXhv06dDmC/lEdj+yhgsaaznUHHOcaQDIKWYnMPXjhjelqWfGEXPPFr SRMu22OQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nd5uC-00AXsS-IM; Sat, 09 Apr 2022 07:53:12 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 5DAE8300299; Sat, 9 Apr 2022 09:53:09 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 1C2B820C50BE8; Sat, 9 Apr 2022 09:53:09 +0200 (CEST) Date: Sat, 9 Apr 2022 09:53:09 +0200 From: Peter Zijlstra To: cgel.zte@gmail.com Cc: akpm@linux-foundation.org, david@redhat.com, corbet@lwn.net, bsingharora@gmail.com, mike.kravetz@oracle.com, yang.yang29@zte.com.cn, wang.yong12@zte.com.cn, ran.xiaokai@zte.com.cn, jiang.xuexin@zte.com.cn, thomas.orgis@uni-hamburg.de, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, sfr@canb.auug.org.au Subject: Re: [PATCH v2] delayacct: track delays from write-protect copy Message-ID: References: <20220409014342.2505532-1-yang.yang29@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220409014342.2505532-1-yang.yang29@zte.com.cn> X-Stat-Signature: szop9hndjswu9e8wc1sp4r6tqjj3tec1 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6EBED100002 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=biNBw+Am; dmarc=none; spf=none (imf14.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org X-Rspam-User: X-HE-Tag: 1649490811-195156 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 09, 2022 at 01:43:44AM +0000, cgel.zte@gmail.com wrote: > From: Yang Yang > > Delay accounting does not track the delay of write-protect copy. When > tasks trigger many write-protect copys(include COW and unsharing of > anonymous pages[1]), it may spend a amount of time waiting for them. > To get the delay of tasks in write-protect copy, could help users to > evaluate the impact of using KSM or fork() or GUP. > > Also update tools/accounting/getdelays.c: > > / # ./getdelays -dl -p 231 > print delayacct stats ON > listen forever > PID 231 > > CPU count real total virtual total delay total delay average > 6247 1859000000 2154070021 1674255063 0.268ms > IO count delay total delay average > 0 0 0ms > SWAP count delay total delay average > 0 0 0ms > RECLAIM count delay total delay average > 0 0 0ms > THRASHING count delay total delay average > 0 0 0ms > COMPACT count delay total delay average > 3 72758 0ms > WPCOPY count delay total delay average > 3635 271567604 0ms > > [1] commit 31cc5bc4af70("mm: support GUP-triggered unsharing of anonymous pages") > > Signed-off-by: Yang Yang > Reviewed-by: David Hildenbrand > Reviewed-by: Jiang Xuexin > Reviewed-by: Ran Xiaokai > Reviewed-by: wangyong As per always; I refuse to take patches from cgel.zte@gmail.com. Because yet again From and Sender don't match. If you want me to consider your email, please send from the email address you've listed in your SoB.