From: Peter Zijlstra <peterz@infradead.org>
To: cgel.zte@gmail.com
Cc: akpm@linux-foundation.org, david@redhat.com, corbet@lwn.net,
bsingharora@gmail.com, mike.kravetz@oracle.com,
yang.yang29@zte.com.cn, wang.yong12@zte.com.cn,
ran.xiaokai@zte.com.cn, jiang.xuexin@zte.com.cn,
thomas.orgis@uni-hamburg.de, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
sfr@canb.auug.org.au
Subject: Re: [PATCH v2] delayacct: track delays from write-protect copy
Date: Sat, 9 Apr 2022 09:53:09 +0200 [thread overview]
Message-ID: <YlE7ZVMfAhs4Ba27@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20220409014342.2505532-1-yang.yang29@zte.com.cn>
On Sat, Apr 09, 2022 at 01:43:44AM +0000, cgel.zte@gmail.com wrote:
> From: Yang Yang <yang.yang29@zte.com.cn>
>
> Delay accounting does not track the delay of write-protect copy. When
> tasks trigger many write-protect copys(include COW and unsharing of
> anonymous pages[1]), it may spend a amount of time waiting for them.
> To get the delay of tasks in write-protect copy, could help users to
> evaluate the impact of using KSM or fork() or GUP.
>
> Also update tools/accounting/getdelays.c:
>
> / # ./getdelays -dl -p 231
> print delayacct stats ON
> listen forever
> PID 231
>
> CPU count real total virtual total delay total delay average
> 6247 1859000000 2154070021 1674255063 0.268ms
> IO count delay total delay average
> 0 0 0ms
> SWAP count delay total delay average
> 0 0 0ms
> RECLAIM count delay total delay average
> 0 0 0ms
> THRASHING count delay total delay average
> 0 0 0ms
> COMPACT count delay total delay average
> 3 72758 0ms
> WPCOPY count delay total delay average
> 3635 271567604 0ms
>
> [1] commit 31cc5bc4af70("mm: support GUP-triggered unsharing of anonymous pages")
>
> Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
> Reviewed-by: David Hildenbrand <david@redhat.com>
> Reviewed-by: Jiang Xuexin <jiang.xuexin@zte.com.cn>
> Reviewed-by: Ran Xiaokai <ran.xiaokai@zte.com.cn>
> Reviewed-by: wangyong <wang.yong12@zte.com.cn>
As per always; I refuse to take patches from cgel.zte@gmail.com. Because
yet again From and Sender don't match.
If you want me to consider your email, please send from the email
address you've listed in your SoB.
next prev parent reply other threads:[~2022-04-09 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 1:43 cgel.zte
2022-04-09 7:53 ` Peter Zijlstra [this message]
2022-04-09 8:31 ` CGEL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlE7ZVMfAhs4Ba27@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=cgel.zte@gmail.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=jiang.xuexin@zte.com.cn \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=ran.xiaokai@zte.com.cn \
--cc=sfr@canb.auug.org.au \
--cc=thomas.orgis@uni-hamburg.de \
--cc=wang.yong12@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox