From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6521EC433EF for ; Sat, 9 Apr 2022 01:33:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F08FB6B0071; Fri, 8 Apr 2022 21:33:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E90906B0073; Fri, 8 Apr 2022 21:33:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D30CB6B0074; Fri, 8 Apr 2022 21:33:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id C55C56B0071 for ; Fri, 8 Apr 2022 21:33:24 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7B6B3AAAE5 for ; Sat, 9 Apr 2022 01:33:24 +0000 (UTC) X-FDA: 79335617928.24.49FDF84 Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by imf08.hostedemail.com (Postfix) with ESMTP id DE515160002 for ; Sat, 9 Apr 2022 01:33:23 +0000 (UTC) Date: Fri, 8 Apr 2022 18:33:14 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1649468002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3iwAnic9ZaGk3gFDQP/Vj3cKdzxhwN/VVb3lVGd9RF0=; b=xtOHEkxMqZl4HOoB3ggEH7wb9JOUSzuKUEFWhvfRm8vvZUtmAR1tH9Q835aO1sIbjQknne 3ZHK6azomPxS45CT7A26DaKWdQhMnBeskt/GdBIVzO82XMqe0jiyPB8UjDhcIK5eUlCDOK eHGWMNHjS37/F+aBBI4Ek8+/qIwLHO8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Yosry Ahmed Cc: Johannes Weiner , Michal Hocko , Shakeel Butt , Andrew Morton , David Rientjes , Tejun Heo , Zefan Li , Jonathan Corbet , Shuah Khan , Yu Zhao , Dave Hansen , Wei Xu , Greg Thelen , Chen Wandun , Vaibhav Jain , Michal =?iso-8859-1?Q?Koutn=FD?= , Tim Chen , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 2/4] selftests: cgroup: return the errno of write() in cg_write() on failure Message-ID: References: <20220408045743.1432968-1-yosryahmed@google.com> <20220408045743.1432968-3-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220408045743.1432968-3-yosryahmed@google.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Stat-Signature: s6by6t3zfx9m5r9ymnt6t8z34dzepawz Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=xtOHEkxM; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf08.hostedemail.com: domain of roman.gushchin@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: DE515160002 X-HE-Tag: 1649468003-792419 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 08, 2022 at 04:57:41AM +0000, Yosry Ahmed wrote: > Currently, cg_write() returns 0 on success and -1 on failure. Modify it > to return the errno of write() syscall when write() fails. > > Signed-off-by: Yosry Ahmed > --- > tools/testing/selftests/cgroup/cgroup_util.c | 32 +++++++++++--------- > 1 file changed, 17 insertions(+), 15 deletions(-) > > diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c > index dbaa7aabbb4a..3b6bb09985fa 100644 > --- a/tools/testing/selftests/cgroup/cgroup_util.c > +++ b/tools/testing/selftests/cgroup/cgroup_util.c > @@ -38,23 +38,23 @@ static ssize_t read_text(const char *path, char *buf, size_t max_len) > return len; > } > > -static ssize_t write_text(const char *path, char *buf, ssize_t len) > +/* > + * Returns: > + * success -> 0 > + * open() failure -> -1 Is there a reason why we can't return errno in this case as well? It would be more straightforward. Otherwise the change looks good to me.