From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AE85C433EF for ; Sat, 9 Apr 2022 01:13:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3B076B0071; Fri, 8 Apr 2022 21:13:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E9EA6B0073; Fri, 8 Apr 2022 21:13:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B1876B0074; Fri, 8 Apr 2022 21:13:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0115.hostedemail.com [216.40.44.115]) by kanga.kvack.org (Postfix) with ESMTP id 7CF8B6B0071 for ; Fri, 8 Apr 2022 21:13:43 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2F94FA78C2 for ; Sat, 9 Apr 2022 01:13:43 +0000 (UTC) X-FDA: 79335568326.21.EF9D898 Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by imf26.hostedemail.com (Postfix) with ESMTP id 55075140005 for ; Sat, 9 Apr 2022 01:13:42 +0000 (UTC) Date: Fri, 8 Apr 2022 18:13:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1649466820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=H//e2ty06NElxV3oXbEOWS2Nb6fAWBDWPPJzb55T3rY=; b=XapiOUYqHdDb2K9tAA0ftrN5h20ybKOWHg0Iy/mqlm/WVinf4DBP7ahmYtxacOGutc2mn+ /cfvwtisoA3IBAhwkTQzrE/nnr8q+0Iz01Zfw/1SaelKbAteprCeRQ3avIk7jvNtWWpjCs WFvmxmZYFGMacn8G4oNFAGXKJEkLHa8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Yosry Ahmed Cc: Johannes Weiner , Michal Hocko , Shakeel Butt , Andrew Morton , David Rientjes , Tejun Heo , Zefan Li , Jonathan Corbet , Shuah Khan , Yu Zhao , Dave Hansen , Wei Xu , Greg Thelen , Chen Wandun , Vaibhav Jain , Michal =?iso-8859-1?Q?Koutn=FD?= , Tim Chen , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Michal Hocko Subject: Re: [PATCH v3 1/4] memcg: introduce per-memcg reclaim interface Message-ID: References: <20220408045743.1432968-1-yosryahmed@google.com> <20220408045743.1432968-2-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220408045743.1432968-2-yosryahmed@google.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 55075140005 X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XapiOUYq; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of roman.gushchin@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev X-Stat-Signature: qsh9g3trdzyz54qhnawkdzjtogy3o9gz X-HE-Tag: 1649466822-4494 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 08, 2022 at 04:57:40AM +0000, Yosry Ahmed wrote: > From: Shakeel Butt > > Introduce a memcg interface to trigger memory reclaim on a memory cgroup. > > Use case: Proactive Reclaim > --------------------------- > > A userspace proactive reclaimer can continuously probe the memcg to > reclaim a small amount of memory. This gives more accurate and > up-to-date workingset estimation as the LRUs are continuously > sorted and can potentially provide more deterministic memory > overcommit behavior. The memory overcommit controller can provide > more proactive response to the changing behavior of the running > applications instead of being reactive. > > A userspace reclaimer's purpose in this case is not a complete replacement > for kswapd or direct reclaim, it is to proactively identify memory savings > opportunities and reclaim some amount of cold pages set by the policy > to free up the memory for more demanding jobs or scheduling new jobs. > > A user space proactive reclaimer is used in Google data centers. > Additionally, Meta's TMO paper recently referenced a very similar > interface used for user space proactive reclaim: > https://dl.acm.org/doi/pdf/10.1145/3503222.3507731 > > Benefits of a user space reclaimer: > ----------------------------------- > > 1) More flexible on who should be charged for the cpu of the memory > reclaim. For proactive reclaim, it makes more sense to be centralized. > > 2) More flexible on dedicating the resources (like cpu). The memory > overcommit controller can balance the cost between the cpu usage and > the memory reclaimed. > > 3) Provides a way to the applications to keep their LRUs sorted, so, > under memory pressure better reclaim candidates are selected. This also > gives more accurate and uptodate notion of working set for an > application. > > Why memory.high is not enough? > ------------------------------ > > - memory.high can be used to trigger reclaim in a memcg and can > potentially be used for proactive reclaim. > However there is a big downside in using memory.high. It can potentially > introduce high reclaim stalls in the target application as the > allocations from the processes or the threads of the application can hit > the temporary memory.high limit. > > - Userspace proactive reclaimers usually use feedback loops to decide > how much memory to proactively reclaim from a workload. The metrics > used for this are usually either refaults or PSI, and these metrics > will become messy if the application gets throttled by hitting the > high limit. > > - memory.high is a stateful interface, if the userspace proactive > reclaimer crashes for any reason while triggering reclaim it can leave > the application in a bad state. > > - If a workload is rapidly expanding, setting memory.high to proactively > reclaim memory can result in actually reclaiming more memory than > intended. > > The benefits of such interface and shortcomings of existing interface > were further discussed in this RFC thread: > https://lore.kernel.org/linux-mm/5df21376-7dd1-bf81-8414-32a73cea45dd@google.com/ > > Interface: > ---------- > > Introducing a very simple memcg interface 'echo 10M > memory.reclaim' to > trigger reclaim in the target memory cgroup. > > The interface is introduced as a nested-keyed file to allow for future > optional arguments to be easily added to configure the behavior of > reclaim. > > Possible Extensions: > -------------------- > > - This interface can be extended with an additional parameter or flags > to allow specifying one or more types of memory to reclaim from (e.g. > file, anon, ..). > > - The interface can also be extended with a node mask to reclaim from > specific nodes. This has use cases for reclaim-based demotion in memory > tiering systens. > > - A similar per-node interface can also be added to support proactive > reclaim and reclaim-based demotion in systems without memcg. > > - Add a timeout parameter to make it easier for user space to call the > interface without worrying about being blocked for an undefined amount > of time. > > For now, let's keep things simple by adding the basic functionality. > > [yosryahmed@google.com: refreshed to current master, updated commit > message based on recent discussions and use cases] > Signed-off-by: Shakeel Butt > Signed-off-by: Yosry Ahmed > Acked-by: Johannes Weiner > Acked-by: Michal Hocko > Acked-by: Wei Xu Acked-by: Roman Gushchin Thank you for incorporating all the feedback! Nice work!