From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFF81C433EF for ; Tue, 19 Apr 2022 21:11:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 579556B0072; Tue, 19 Apr 2022 17:11:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 528C46B0073; Tue, 19 Apr 2022 17:11:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 418016B0074; Tue, 19 Apr 2022 17:11:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0031.hostedemail.com [216.40.44.31]) by kanga.kvack.org (Postfix) with ESMTP id 355C06B0072 for ; Tue, 19 Apr 2022 17:11:57 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D405D8249980 for ; Tue, 19 Apr 2022 21:11:56 +0000 (UTC) X-FDA: 79374875832.28.A76EBEB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id 8FA44120006 for ; Tue, 19 Apr 2022 21:11:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XUSqcVdg0spSnmkggLG/VT+Cpf9iOYyjn8OPASpb5r0=; b=GzmSekdEIggeVCZKvlGzHIM7O/ MnjQTR8Y0dutg4uEbqgFK5rDkhfeaI9hwSJjwOoi/8Z0I8cB4N6DpHNvuXjO5Nv/1PxQRRFQbaQG+ vgb5kURU5/RidUxrvPonxYDhRd2k1RjoCcI9bTTTm4VF2FP12iBHXZ91UG8r8mjgF7pJmDfvu5juG Y9nVva19cvDpUfDW0/Jv0da+ahPVTazMwWe63iD7KTgZwrdAv8PdPWkpuPNIz3NjuF+uDCI46OsVD ClGp+Zh+F/f5Ac4bWIVSvPGsdWJ+bx72a0UMeaa3dEYyFOa3sZbwDkOzgkPGZYww2miMSOdqT7Sqa IQ2bzVLA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngv8Z-003VTM-6f; Tue, 19 Apr 2022 21:11:51 +0000 Date: Tue, 19 Apr 2022 22:11:51 +0100 From: Matthew Wilcox To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, roman.gushchin@linux.dev, hannes@cmpxchg.org Subject: Re: [PATCH 1/4] lib/printbuf: New data structure for heap-allocated strings Message-ID: References: <20220419203202.2670193-1-kent.overstreet@gmail.com> <20220419203202.2670193-2-kent.overstreet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220419203202.2670193-2-kent.overstreet@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8FA44120006 X-Stat-Signature: p8bmgcgp7qtnub93b4mqfkf1th719xda Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=GzmSekdE; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1650402715-751580 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 19, 2022 at 04:31:59PM -0400, Kent Overstreet wrote: > +static const char si_units[] = "?kMGTPEZY"; > + > +void pr_human_readable_u64(struct printbuf *buf, u64 v) The person who wrote string_get_size() spent a lot more time thinking about corner-cases than you did ;-)