From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4A16C433F5 for ; Tue, 19 Apr 2022 18:33:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31E8A6B0071; Tue, 19 Apr 2022 14:33:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B38F6B0073; Tue, 19 Apr 2022 14:33:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 147FB6B0074; Tue, 19 Apr 2022 14:33:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 03AE56B0071 for ; Tue, 19 Apr 2022 14:33:28 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C58A72325B for ; Tue, 19 Apr 2022 18:33:27 +0000 (UTC) X-FDA: 79374476454.11.DFE99E2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 23BE1C001C for ; Tue, 19 Apr 2022 18:33:25 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A4C0261532; Tue, 19 Apr 2022 18:33:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87877C385A5; Tue, 19 Apr 2022 18:33:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650393206; bh=H1oFXf3wjHIKjyaD0GET6MgKHiZJtaQEQDv0ySaB/Vs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zWArRDd8xXHD/+D6eA5paKurMw53dJH/3JxkKZGZG+KZ46ea5EbwOFw7jVLhqNXX+ g7l1S17XK4upMUQLpZO0MqOTbUnL9od6JxT/+e2jABkPr0Zzb/sy6rGxNmNOlbHXcX xqO57L4pfrcghUzyZXLdOeT/RoMcFXCOEvnNgLFo= Date: Tue, 19 Apr 2022 20:33:22 +0200 From: Greg KH To: Roman Gushchin Cc: Andrew Morton , linux-mm@kvack.org, Dave Chinner , linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Shakeel Butt , Yang Shi Subject: Re: [PATCH rfc 0/5] mm: introduce shrinker sysfs interface Message-ID: References: <20220416002756.4087977-1-roman.gushchin@linux.dev> <20220418212709.42f2ba15e00999bb57086b27@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: gzbax4u4nasakjurkumgb1jkxhan4d4w X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=zWArRDd8; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf10.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 23BE1C001C X-HE-Tag: 1650393205-1967 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 19, 2022 at 10:52:44AM -0700, Roman Gushchin wrote: > On Mon, Apr 18, 2022 at 09:27:09PM -0700, Andrew Morton wrote: > > > The folder > > > contains "count" and "scan" files, which allow to trigger count_objects() > > > and scan_objects() callbacks. For memcg-aware and numa-aware shrinkers > > > count_memcg, scan_memcg, count_node, scan_node, count_memcg_node > > > and scan_memcg_node are additionally provided. They allow to get per-memcg > > > and/or per-node object count and shrink only a specific memcg/node. > > > > > > To make debugging more pleasant, the patchset also names all shrinkers, > > > so that sysfs entries can have more meaningful names. > > > > I also was wondering "why not debugfs". > > Fair enough, moving to debugfs in v1. Thank you, that keeps me from complaining about how badly you were abusing sysfs in this patchset :)