From: Greg KH <gregkh@linuxfoundation.org>
To: Roman Gushchin <roman.gushchin@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Dave Chinner <dchinner@redhat.com>,
linux-kernel@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Shakeel Butt <shakeelb@google.com>,
Yang Shi <shy828301@gmail.com>
Subject: Re: [PATCH rfc 0/5] mm: introduce shrinker sysfs interface
Date: Tue, 19 Apr 2022 20:33:22 +0200 [thread overview]
Message-ID: <Yl8AchMeoHkG1e9l@kroah.com> (raw)
In-Reply-To: <Yl727M1Dxm+vC/R1@carbon>
On Tue, Apr 19, 2022 at 10:52:44AM -0700, Roman Gushchin wrote:
> On Mon, Apr 18, 2022 at 09:27:09PM -0700, Andrew Morton wrote:
> > > The folder
> > > contains "count" and "scan" files, which allow to trigger count_objects()
> > > and scan_objects() callbacks. For memcg-aware and numa-aware shrinkers
> > > count_memcg, scan_memcg, count_node, scan_node, count_memcg_node
> > > and scan_memcg_node are additionally provided. They allow to get per-memcg
> > > and/or per-node object count and shrink only a specific memcg/node.
> > >
> > > To make debugging more pleasant, the patchset also names all shrinkers,
> > > so that sysfs entries can have more meaningful names.
> >
> > I also was wondering "why not debugfs".
>
> Fair enough, moving to debugfs in v1.
Thank you, that keeps me from complaining about how badly you were
abusing sysfs in this patchset :)
next prev parent reply other threads:[~2022-04-19 18:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-16 0:27 Roman Gushchin
2022-04-16 0:27 ` [PATCH rfc 1/5] mm: introduce sysfs interface for debugging kernel shrinker Roman Gushchin
2022-04-16 1:35 ` Hillf Danton
2022-04-16 0:27 ` [PATCH rfc 2/5] mm: memcontrol: introduce mem_cgroup_ino() and mem_cgroup_get_from_ino() Roman Gushchin
2022-04-16 0:27 ` [PATCH rfc 3/5] mm: introduce memcg interfaces for shrinker sysfs Roman Gushchin
2022-04-16 0:27 ` [PATCH rfc 4/5] mm: introduce numa " Roman Gushchin
2022-04-16 0:27 ` [PATCH rfc 5/5] mm: provide shrinkers with names Roman Gushchin
2022-04-18 9:27 ` [PATCH rfc 0/5] mm: introduce shrinker sysfs interface Mike Rapoport
2022-04-18 17:27 ` Roman Gushchin
2022-04-19 6:33 ` Mike Rapoport
2022-04-19 17:58 ` Roman Gushchin
2022-04-19 4:27 ` Andrew Morton
2022-04-19 17:52 ` Roman Gushchin
2022-04-19 18:25 ` Andrew Morton
2022-04-19 18:43 ` Roman Gushchin
2022-04-19 18:33 ` Greg KH [this message]
2022-04-19 18:20 ` Kent Overstreet
2022-04-19 18:58 ` Roman Gushchin
2022-04-19 19:46 ` Kent Overstreet
2022-04-19 18:36 ` Kent Overstreet
2022-04-19 18:50 ` Roman Gushchin
2022-04-19 21:10 ` Kent Overstreet
2022-04-20 22:24 ` Yang Shi
2022-04-20 23:23 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl8AchMeoHkG1e9l@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=dchinner@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=shy828301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox