From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A34A9C433EF for ; Wed, 20 Apr 2022 06:58:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30CD66B0073; Wed, 20 Apr 2022 02:58:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BCB46B0074; Wed, 20 Apr 2022 02:58:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AABD6B0075; Wed, 20 Apr 2022 02:58:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 0E7B26B0073 for ; Wed, 20 Apr 2022 02:58:40 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C94CD272E for ; Wed, 20 Apr 2022 06:58:39 +0000 (UTC) X-FDA: 79376354358.28.B12002C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf09.hostedemail.com (Postfix) with ESMTP id 34CE6140018 for ; Wed, 20 Apr 2022 06:58:38 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id CC1A21F385; Wed, 20 Apr 2022 06:58:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1650437917; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4fTOnm8X7fTon8J5U2DDAjOf8lbd7MDCm+komIQ5sL0=; b=WMY2zI9jyNpoVyqQAkq9ncq+P8HDI7MTSGSrE4wMw3uGvgXvBbmaP1FXONFiJg1U6DFoei A3GPwI6uA0I7lxiDzAI9nl8t22BQJpI/yWt7l9XoE8pvd8UxtXD2EmfhJ/ZD6fjuALN07/ ijsv9wKTyYoaEh60dM/LzVIfsk2EwPE= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 8D58B2C14B; Wed, 20 Apr 2022 06:58:37 +0000 (UTC) Date: Wed, 20 Apr 2022 08:58:36 +0200 From: Michal Hocko To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, roman.gushchin@linux.dev, hannes@cmpxchg.org Subject: Re: [PATCH 3/4] mm: Centralize & improve oom reporting in show_mem.c Message-ID: References: <20220419203202.2670193-1-kent.overstreet@gmail.com> <20220419203202.2670193-4-kent.overstreet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220419203202.2670193-4-kent.overstreet@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 34CE6140018 X-Stat-Signature: 5bfpujautjds4p9fhe9njzstdb1e9d7n Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=WMY2zI9j; spf=pass (imf09.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-HE-Tag: 1650437918-256688 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002629, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 19-04-22 16:32:01, Kent Overstreet wrote: > This patch: > - Moves lib/show_mem.c to mm/show_mem.c Sure, why not. Should be a separate patch. > - Changes show_mem() to always report on slab usage > - Instead of reporting on all slabs, we only report on top 10 slabs, > and in sorted order > - Also reports on shrinkers, with the new shrinkers_to_text(). Why do we need/want this? It would be also great to provide an example of why the new output is better (in which cases) than the existing one. -- Michal Hocko SUSE Labs