From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6550C433F5 for ; Wed, 20 Apr 2022 11:48:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 570226B0072; Wed, 20 Apr 2022 07:48:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 520F16B0073; Wed, 20 Apr 2022 07:48:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40F506B0074; Wed, 20 Apr 2022 07:48:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 34AAE6B0072 for ; Wed, 20 Apr 2022 07:48:07 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E2DFF229C5 for ; Wed, 20 Apr 2022 11:48:06 +0000 (UTC) X-FDA: 79377083772.22.B03C6E1 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf17.hostedemail.com (Postfix) with ESMTP id 67A814001C for ; Wed, 20 Apr 2022 11:48:04 +0000 (UTC) Received: by mail-pl1-f182.google.com with SMTP id s14so1537694plk.8 for ; Wed, 20 Apr 2022 04:48:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=G/ioqyMtGhgT8ISEDn/usHLH5R3KJLV/B97GOzazafc=; b=U+gJXLEVbej5eDWOrkmQPZgsCrTk1tamX1cWQ23CG/ttIdcnYb+7A+1Fk7B75njiNH 1o6ZrnHjQy8bAyRNl80sGvpGpIalt8lMq+THKk6pBQDoJpvzh7nGEv4Bg5XOQKCPFL4v phdWyntUB5dkckSslPzNqIYZtRFXhwtVCm/lw1wdtKUHy87OIv4cF+KvtugIKWQ56yoZ EFmoalGWQAJM5cGy1trIWgvZ7zF5o2EvfGjYxZv4owCGHGRc6ovmVi0kNidcfHCGz5TW lwcijgS+UnPZ3wchwNg4+8hT/NmplLT7l6NCgb6rz/kYZnfCWOHMSasevAb3e7veOigT tfbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=G/ioqyMtGhgT8ISEDn/usHLH5R3KJLV/B97GOzazafc=; b=ytZdeJYwdSVfn9bfJlb70iX5zQSRkd5eh79Uq3q7B3llojlgeML5O1gHPdcyEArokm THXfKlKZhvVZ8XGkpe38cwU96ijzZ1tzmZHeUSyiXBFW11AW3t1vNG/hpjHTehRUxEnr 10NaeIWRu5plLK1LcBZKep+YUBkUkKw3uYh9ZiJYtGxiVgK1lFhH5qhpg7hXtjYM8Ozf f8Rxz+NBgFPkEOpw55vp7lzDXc//3nKPtRobXgkRvhks60Y041kb00p0KCwQyGeB3EBk H8otP7lreqYDbjJqd/2MWXxud7iQvTh58/4ETY+wzAtV0tsMUwZ9xcEUBFzApHK30zXk lyYg== X-Gm-Message-State: AOAM530Vxr9sk6ydYobPvecUQvRRnsu6S2z1GAEDK6YCLzbMg8uKWJfH fkJ0nL3V/riMIs9oEYwP3Q0= X-Google-Smtp-Source: ABdhPJyVYe1VeH+uzXmiBpeuXKNxGvL1Jy3NFBKwFB13ZUZc3QOmA/ZWHJ+01MyNJW9hI5nxDfASxQ== X-Received: by 2002:a17:903:1d0:b0:158:d4c7:99c2 with SMTP id e16-20020a17090301d000b00158d4c799c2mr20287232plh.63.1650455285344; Wed, 20 Apr 2022 04:48:05 -0700 (PDT) Received: from hyeyoo ([114.29.24.243]) by smtp.gmail.com with ESMTPSA id p1-20020a62ab01000000b0050acad694a3sm2345756pff.206.2022.04.20.04.47.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 04:48:03 -0700 (PDT) Date: Wed, 20 Apr 2022 20:47:56 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Miaohe Lin Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/slub: remove unneeded return value of slab_pad_check Message-ID: References: <20220419120352.37825-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220419120352.37825-1-linmiaohe@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 67A814001C X-Stat-Signature: fowjxegrzk3ca8byk8cudtsuor3kxkz4 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=U+gJXLEV; spf=pass (imf17.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1650455284-162371 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 19, 2022 at 08:03:52PM +0800, Miaohe Lin wrote: > The return value of slab_pad_check is never used. So we can make it return > void now. > > Signed-off-by: Miaohe Lin > --- > mm/slub.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 6dc703488d30..1f699ddfff7f 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1017,7 +1017,7 @@ static int check_pad_bytes(struct kmem_cache *s, struct slab *slab, u8 *p) > } > > /* Check the pad bytes at the end of a slab page */ > -static int slab_pad_check(struct kmem_cache *s, struct slab *slab) > +static void slab_pad_check(struct kmem_cache *s, struct slab *slab) > { > u8 *start; > u8 *fault; > @@ -1027,21 +1027,21 @@ static int slab_pad_check(struct kmem_cache *s, struct slab *slab) > int remainder; > > if (!(s->flags & SLAB_POISON)) > - return 1; > + return; > > start = slab_address(slab); > length = slab_size(slab); > end = start + length; > remainder = length % s->size; > if (!remainder) > - return 1; > + return; > > pad = end - remainder; > metadata_access_enable(); > fault = memchr_inv(kasan_reset_tag(pad), POISON_INUSE, remainder); > metadata_access_disable(); > if (!fault) > - return 1; > + return; > while (end > fault && end[-1] == POISON_INUSE) > end--; > > @@ -1050,7 +1050,6 @@ static int slab_pad_check(struct kmem_cache *s, struct slab *slab) > print_section(KERN_ERR, "Padding ", pad, remainder); > > restore_bytes(s, "slab padding", POISON_INUSE, fault, end); > - return 0; > } > > static int check_object(struct kmem_cache *s, struct slab *slab, > @@ -1642,8 +1641,7 @@ static inline int free_debug_processing( > void *head, void *tail, int bulk_cnt, > unsigned long addr) { return 0; } > > -static inline int slab_pad_check(struct kmem_cache *s, struct slab *slab) > - { return 1; } > +static inline void slab_pad_check(struct kmem_cache *s, struct slab *slab) {} > static inline int check_object(struct kmem_cache *s, struct slab *slab, > void *object, u8 val) { return 1; } > static inline void add_full(struct kmem_cache *s, struct kmem_cache_node *n, Seems the return value was not used even at birth of SLUB. Looks good to me. Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Thanks! > -- > 2.23.0 > > -- Thanks, Hyeonggon