From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 190A1C433EF for ; Tue, 5 Apr 2022 22:33:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3ACAA6B0072; Tue, 5 Apr 2022 18:33:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35C596B0073; Tue, 5 Apr 2022 18:33:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 224826B0074; Tue, 5 Apr 2022 18:33:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 0EB0A6B0072 for ; Tue, 5 Apr 2022 18:33:32 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C8C32F44 for ; Tue, 5 Apr 2022 22:33:21 +0000 (UTC) X-FDA: 79324277802.11.5E8EAB3 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id 1C58B40017 for ; Tue, 5 Apr 2022 22:33:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=s5Rv2jt7aGLImfLJIiM/5w3K8YUbSOEx+pvCk6I5VMo=; b=rqdoUew930ZZ6zrAnlfvmOF/zf +YntEDiQq+lDqmtSifeD/BGDKf4g7GkHYLxudkmzdyK5cgH/wZucpnSc1cOEeqX5tzdZylyEm9uz5 KjdjRJUUJa9gUj9572C6PlpVQLKxTlLKuASQa0lhQMLBp52OQqySbhM/BMq/qghF0J67yro+frIqg XoDZgXOLgGwC3tfbvt999mOTUy6LqjcaDRWq7nkQZS2B3zJXHLy8ItBQFTzk4vxBpz7SFXJ3cmjCe SB/I/ptIkVnavZf3lWoOGDw3MGZDfUUipM9KeUyy8WAfhHKBIIH3x+GfmL+nyBA2iw4nUlGS8cNsW Tu+LgHDw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbrjU-0077Ix-P6; Tue, 05 Apr 2022 22:33:04 +0000 Date: Tue, 5 Apr 2022 23:33:04 +0100 From: Matthew Wilcox To: Sidhartha Kumar Cc: shuah@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] selftest/vm clarify error statement in gup_test Message-ID: References: <20220405214809.3351223-1-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220405214809.3351223-1-sidhartha.kumar@oracle.com> X-Stat-Signature: fi8kjc8umn5njwywppuux366we47qacg X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1C58B40017 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rqdoUew9; dmarc=none; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-HE-Tag: 1649198000-896639 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 05, 2022 at 09:48:09PM +0000, Sidhartha Kumar wrote: > - perror("open"); > - exit(1); > + switch (errno) { > + case EACCES: > + if (getuid()) > + printf("Please run this test as root\n"); Shouldn't all these be fprintf(stderr, ...); ?