From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 864DFC433F5 for ; Mon, 4 Apr 2022 19:11:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0FB46B0073; Mon, 4 Apr 2022 15:11:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC05D8D0001; Mon, 4 Apr 2022 15:11:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 988ED6B0075; Mon, 4 Apr 2022 15:11:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0164.hostedemail.com [216.40.44.164]) by kanga.kvack.org (Postfix) with ESMTP id 8A6B26B0073 for ; Mon, 4 Apr 2022 15:11:21 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 458ADAB1DA for ; Mon, 4 Apr 2022 19:11:11 +0000 (UTC) X-FDA: 79320139542.22.7847571 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by imf25.hostedemail.com (Postfix) with ESMTP id C2158A0015 for ; Mon, 4 Apr 2022 19:11:10 +0000 (UTC) Date: Mon, 4 Apr 2022 12:11:05 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1649099469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IQhgBimXjsff3C4o+7n/5Q3wYW2UqkiKGEeJ94ihq2Y=; b=mvCuJqdY/cG41YOkKNjL26KNm9A/3wMmhWMTazOGnFypRIqmqp7Za3sv/lZRIEk+DNNR9Z RYaKlu1imlw/XYW7u7VkTHv6GBZ42hhkfKzXjobhMz88QCmYsDX32KJGwK5zbxTpjlZ5Ia EQqU6oPNG5ZMiBRaqVDQe41jtCgiySk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Wei Yang Cc: akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Johannes Weiner Subject: Re: [PATCH] mm/memcg: non-hierarchical mode is deprecated Message-ID: References: <20220403020833.26164-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220403020833.26164-1-richard.weiyang@gmail.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Stat-Signature: xz7wrj1edjhpss9j4y7tb56bjr5bq8qo X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C2158A0015 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=mvCuJqdY; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf25.hostedemail.com: domain of roman.gushchin@linux.dev designates 94.23.1.103 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev X-Rspam-User: X-HE-Tag: 1649099470-436966 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Apr 03, 2022 at 02:08:33AM +0000, Wei Yang wrote: > After commit bef8620cd8e0 ("mm: memcg: deprecate the non-hierarchical > mode"), we won't have a NULL parent except root_mem_cgroup. And this > case is handled when (memcg == root). > > Signed-off-by: Wei Yang > CC: Roman Gushchin > CC: Johannes Weiner Reviewed-by: Roman Gushchin Thanks! > --- > mm/memcontrol.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 2cd8bfdec379..3ceb9b8592b1 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -6587,9 +6587,6 @@ void mem_cgroup_calculate_protection(struct mem_cgroup *root, > return; > > parent = parent_mem_cgroup(memcg); > - /* No parent means a non-hierarchical mode on v1 memcg */ > - if (!parent) > - return; > > if (parent == root) { > memcg->memory.emin = READ_ONCE(memcg->memory.min); > -- > 2.33.1 >