From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66AF3C433F5 for ; Mon, 4 Apr 2022 09:28:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC97C8D0001; Mon, 4 Apr 2022 05:28:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D79246B0074; Mon, 4 Apr 2022 05:28:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C685C8D0001; Mon, 4 Apr 2022 05:28:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id B6AE26B0073 for ; Mon, 4 Apr 2022 05:28:09 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7FCA721E8B for ; Mon, 4 Apr 2022 09:27:59 +0000 (UTC) X-FDA: 79318669878.03.1A8C83B Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf10.hostedemail.com (Postfix) with ESMTP id 87E59C0037 for ; Mon, 4 Apr 2022 09:27:58 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 310E3210DE; Mon, 4 Apr 2022 09:27:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1649064477; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OwAumWcezlls50PruntJTwS4J8Nr3qUaKu9aGBgBgEs=; b=mpv1G9m8vdAxMGUmqMs2ZgJLiHrJG8NmRRJRgSjJkp8vlwqkbtqDCNu0V7MLx7sAqB84UW hct3dBWDtjrzRplcnV9lYZyLRrmKWf/vDGRfJS8RdGbYe4vdXtUY7JgHsXaZfBr0YzoL6N 1TME0jb8pe4fGTsKW1pMDUxzsK3AKf0= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id EF484A3B83; Mon, 4 Apr 2022 09:27:56 +0000 (UTC) Date: Mon, 4 Apr 2022 11:27:53 +0200 From: Michal Hocko To: Wei Yang Cc: akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Roman Gushchin , Johannes Weiner Subject: Re: [PATCH] mm/memcg: non-hierarchical mode is deprecated Message-ID: References: <20220403020833.26164-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220403020833.26164-1-richard.weiyang@gmail.com> X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=mpv1G9m8; spf=pass (imf10.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 87E59C0037 X-Stat-Signature: rpek3hub7595469nsm8ycakcswzjx8xp X-HE-Tag: 1649064478-853395 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun 03-04-22 02:08:33, Wei Yang wrote: > After commit bef8620cd8e0 ("mm: memcg: deprecate the non-hierarchical > mode"), we won't have a NULL parent except root_mem_cgroup. And this > case is handled when (memcg == root). > > Signed-off-by: Wei Yang > CC: Roman Gushchin > CC: Johannes Weiner Acked-by: Michal Hocko Thanks! > --- > mm/memcontrol.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 2cd8bfdec379..3ceb9b8592b1 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -6587,9 +6587,6 @@ void mem_cgroup_calculate_protection(struct mem_cgroup *root, > return; > > parent = parent_mem_cgroup(memcg); > - /* No parent means a non-hierarchical mode on v1 memcg */ > - if (!parent) > - return; > > if (parent == root) { > memcg->memory.emin = READ_ONCE(memcg->memory.min); > -- > 2.33.1 -- Michal Hocko SUSE Labs