From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E76A2C433EF for ; Thu, 31 Mar 2022 00:20:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6AF716B0072; Wed, 30 Mar 2022 20:20:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66A306B0073; Wed, 30 Mar 2022 20:20:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 525E08D0001; Wed, 30 Mar 2022 20:20:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 3F7B66B0072 for ; Wed, 30 Mar 2022 20:20:30 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 01C24BAC for ; Thu, 31 Mar 2022 00:20:29 +0000 (UTC) X-FDA: 79302775020.07.AD7AD5B Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by imf11.hostedemail.com (Postfix) with ESMTP id 536D440007 for ; Thu, 31 Mar 2022 00:20:29 +0000 (UTC) Date: Wed, 30 Mar 2022 17:20:22 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1648686027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kMINQAWO37CD+sVTlC/+ZMx9SRomlyJk24EcdjGWpeg=; b=wjiU1M6n3t656w0pWJcX+6aZPo7iWKh4pkJ21tOjlUEuOgNEycFbGfaLRm62qc3jXJ07iB dzUoeAh0RFkYRBb+iHMxH/+EuvR6VSeac50J4ncNDTQV3gFlcUfaguwKpQjNF2j7xtxJM2 9/0/DJH3LBq0RFHj0pVnZZRYglSeoJY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Wei Yang Cc: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [Patch v2 1/3] mm/memcg: set memcg after css verified and got reference Message-ID: References: <20220330234719.18340-1-richard.weiyang@gmail.com> <20220330234719.18340-2-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220330234719.18340-2-richard.weiyang@gmail.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Stat-Signature: mscscpdtnzt39w9fkhyjzcggwd3dbcwi Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=wjiU1M6n; spf=pass (imf11.hostedemail.com: domain of roman.gushchin@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 536D440007 X-HE-Tag: 1648686029-762288 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 30, 2022 at 11:47:17PM +0000, Wei Yang wrote: > Instead of reset memcg when css is either not verified or not got > reference, we can set it after these process. > > No functional change, just simplified the code a little. > > Signed-off-by: Wei Yang > Acked-by: Johannes Weiner Reviewed-by: Roman Gushchin Nice cleanup! > --- > mm/memcontrol.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index dc193e83794d..eed9916cdce5 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1057,15 +1057,10 @@ struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *root, > * is provided by the caller, so we know it's alive > * and kicking, and don't take an extra reference. > */ > - memcg = mem_cgroup_from_css(css); > - > - if (css == &root->css) > - break; > - > - if (css_tryget(css)) > + if (css == &root->css || css_tryget(css)) { > + memcg = mem_cgroup_from_css(css); > break; > - > - memcg = NULL; > + } > } > > if (reclaim) { > -- > 2.33.1 > >