From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E28AC433F5 for ; Tue, 29 Mar 2022 14:00:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D25338D0003; Tue, 29 Mar 2022 10:00:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD3FA8D0001; Tue, 29 Mar 2022 10:00:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC3C38D0003; Tue, 29 Mar 2022 10:00:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0045.hostedemail.com [216.40.44.45]) by kanga.kvack.org (Postfix) with ESMTP id AC1938D0001 for ; Tue, 29 Mar 2022 10:00:34 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5F8B018293214 for ; Tue, 29 Mar 2022 14:00:34 +0000 (UTC) X-FDA: 79297583988.28.1936327 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf13.hostedemail.com (Postfix) with ESMTP id 939DC2002C for ; Tue, 29 Mar 2022 14:00:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DW2vz9n7HSzWdn+ft84nAj+rMrszzhYr9yUTDRaO1P8=; b=MRlCg1xSuro8i4YkxUqiyVTbPE 8m5IqrXJS1yhHBUV/a1PnP3rvPrO+u0dw55z9xC8hpBA9ayNmC5XKuZCzLaCy6tHWH+nu4ux64m0y NGQn9J43Q/IcegjIfQauUnsJvl+t0G6b3LwuT+EJbe5PaD9fFjsaxAWIdvAr65+KZXSb27ECJFj29 Sz6lvJnoSfGWRiR0NPM1qWksECWSOn79vKXPuYGIchtppLyfOaLEbsAEB1Aq1PWh1xcLSXshR7/XX g+LLS038NUd0/AjuNBM0y9/FjLtuZIuCuYcjyDCkjqT/2Cf8AVQAN7jgVoewHurHBbHfkemQpMwRc PaP1if2g==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZCOb-00CRNG-NJ; Tue, 29 Mar 2022 14:00:29 +0000 Date: Tue, 29 Mar 2022 07:00:29 -0700 From: Christoph Hellwig To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/8] mm/vmscan: introduce helper function reclaim_page_list() Message-ID: References: <20220329132619.18689-1-linmiaohe@huawei.com> <20220329132619.18689-4-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220329132619.18689-4-linmiaohe@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: tn4k6wgg7cwh8yyxd3ernkooimcb7y8m X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 939DC2002C Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=MRlCg1xS; dmarc=none; spf=none (imf13.hostedemail.com: domain of BATV+e525b32aea5d25a0d9b4+6792+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e525b32aea5d25a0d9b4+6792+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: X-HE-Tag: 1648562433-24648 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +static inline unsigned int reclaim_page_list(struct list_head *page_list, struct pglist_data *pgdat) This is completely unreadable with the crazy long lines. Also why would you force inline this?