From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB362C433F5 for ; Tue, 29 Mar 2022 13:50:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 408B88D0006; Tue, 29 Mar 2022 09:50:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B8188D0003; Tue, 29 Mar 2022 09:50:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A7478D0006; Tue, 29 Mar 2022 09:50:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0063.hostedemail.com [216.40.44.63]) by kanga.kvack.org (Postfix) with ESMTP id 1C7D48D0003 for ; Tue, 29 Mar 2022 09:50:43 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CF6858248D52 for ; Tue, 29 Mar 2022 13:50:42 +0000 (UTC) X-FDA: 79297559124.22.7711B22 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id BEEFB1C0014 for ; Tue, 29 Mar 2022 13:50:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=57/4y/ohZjXaSPqFsFf+MEyeDJA1H5R3F1dc2TLdTvQ=; b=J+WxSsdP5WbMw6G0tUtNCsUaPs PwFa58iCP2s/bAtVgD95gOUEVStNvwoJ3MCKvME/CJLVs8Ohzi87+zVtjZ2+CZKiG0YSb5W7LUxay bviJEvD69mcdDeirE2f0Uydrbib/NqA5+UwlW3urkofgJziMT1j0useFfDtqwCUHXngiDA1A9l/VP JZIsigSM6fYx7WmS0ldjwqqjpPdikzRWh7qO9DGgU1UYdkjOitJyoDVh8GmN+pgKq4hcRBuh/ui4p bXUEUZXlfLUvJj72RaMLPVy11Oeu2U7Kg9qg+MCUFze4vVayNN1c5fKqV294c3AC7VSojYGVIsi6G V+BcgDzw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZCF4-000KZD-AM; Tue, 29 Mar 2022 13:50:38 +0000 Date: Tue, 29 Mar 2022 14:50:38 +0100 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/8] mm/vmscan: introduce helper function reclaim_page_list() Message-ID: References: <20220329132619.18689-1-linmiaohe@huawei.com> <20220329132619.18689-4-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220329132619.18689-4-linmiaohe@huawei.com> X-Stat-Signature: 68steyjazuh1ktesngcqx8ndumipjh95 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=J+WxSsdP; dmarc=none; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: BEEFB1C0014 X-HE-Tag: 1648561841-466419 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 29, 2022 at 09:26:14PM +0800, Miaohe Lin wrote: > -unsigned long reclaim_pages(struct list_head *page_list) > +static inline unsigned int reclaim_page_list(struct list_head *page_list, struct pglist_data *pgdat) > { > - int nid = NUMA_NO_NODE; > - unsigned int nr_reclaimed = 0; > - LIST_HEAD(node_page_list); > struct reclaim_stat dummy_stat; > + unsigned int nr_reclaimed; > struct page *page; > - unsigned int noreclaim_flag; > struct scan_control sc = { > .gfp_mask = GFP_KERNEL, > .may_writepage = 1, > @@ -2529,6 +2526,24 @@ unsigned long reclaim_pages(struct list_head *page_list) > .no_demotion = 1, > }; > > + nr_reclaimed = shrink_page_list(page_list, pgdat, &sc, &dummy_stat, false); > + while (!list_empty(page_list)) { > + page = lru_to_page(page_list); > + list_del(&page->lru); > + putback_lru_page(page); Why wouldn't you use a folio here?