From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E4ADC433F5 for ; Tue, 29 Mar 2022 06:36:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 492618D0002; Tue, 29 Mar 2022 02:36:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4423A8D0001; Tue, 29 Mar 2022 02:36:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 331E78D0002; Tue, 29 Mar 2022 02:36:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0092.hostedemail.com [216.40.44.92]) by kanga.kvack.org (Postfix) with ESMTP id 2651A8D0001 for ; Tue, 29 Mar 2022 02:36:45 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D79278249980 for ; Tue, 29 Mar 2022 06:36:44 +0000 (UTC) X-FDA: 79296465528.20.35D46E0 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id 7ACAA12000E for ; Tue, 29 Mar 2022 06:36:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BLn23ZPzFztDmKi1r1MS0HG3EmTPbihADR06egULMkA=; b=FU+QQA9ZpAEVDVXWOFgSWn4vAe vCDQ7JhwFailgLwyMcxDwEGJ+pkh3+xhmPZhhGiUlulrXd+bIjD1HH3LmxvaNMppNncIBvBTzXNNE x6QsZ14Ohy4VXLMmOecd5F8fYphuQoWcq0Uitr2CCXm3VIM0xrEtjtg5rBsSpp7WqMg4INJgATACR wZ1CoPa4EflUhSEIb+Z8xsDTycAEU6tE6WOmfBKsv0LTvyaQAB7LJ3XgML5+UiS0rMQTsuLFDVBg+ 2FhvZ3hkHKAqYJMUYyFnqVrbPpx/lwELDbCRjLS2KiSgCpXi37EFDawQ8L4scnU9H3Bviyyh0Bpyh ZM8dZ5gQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZ5T6-00BDGn-0A; Tue, 29 Mar 2022 06:36:40 +0000 Date: Mon, 28 Mar 2022 23:36:39 -0700 From: Christoph Hellwig To: Rolf Eike Beer Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: mm: use mmap_assert_write_locked() instead of open coding it Message-ID: References: <5827758.TJ1SttVevJ@mobilepool36.emlix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5827758.TJ1SttVevJ@mobilepool36.emlix.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=FU+QQA9Z; spf=none (imf29.hostedemail.com: domain of BATV+e525b32aea5d25a0d9b4+6792+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e525b32aea5d25a0d9b4+6792+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 7ACAA12000E X-Stat-Signature: nqfixx1swk4m9fkbnog8b6aoqpu1j6mr X-HE-Tag: 1648535804-239560 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 28, 2022 at 10:24:51AM +0200, Rolf Eike Beer wrote: > In case the lock is actually not held at this point this also avoids a > stale lock reference if built with NDEBUG. The change looks good: Reviewed-by: Christoph Hellwig But I don't think NDEBUG is a thing in the kernel.