From: Christoph Hellwig <hch@infradead.org>
To: Rolf Eike Beer <eb@emlix.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: mm: use mmap_assert_write_locked() instead of open coding it
Date: Mon, 28 Mar 2022 23:36:39 -0700 [thread overview]
Message-ID: <YkKo93R1Fm0JXXtS@infradead.org> (raw)
In-Reply-To: <5827758.TJ1SttVevJ@mobilepool36.emlix.com>
On Mon, Mar 28, 2022 at 10:24:51AM +0200, Rolf Eike Beer wrote:
> In case the lock is actually not held at this point this also avoids a
> stale lock reference if built with NDEBUG.
The change looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
But I don't think NDEBUG is a thing in the kernel.
next prev parent reply other threads:[~2022-03-29 6:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 8:24 Rolf Eike Beer
2022-03-29 6:36 ` Christoph Hellwig [this message]
2022-03-29 6:45 ` Rolf Eike Beer
2022-04-01 2:32 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkKo93R1Fm0JXXtS@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=eb@emlix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox