From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3301DC433F5 for ; Mon, 28 Mar 2022 22:10:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 804CB8D0002; Mon, 28 Mar 2022 18:10:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B1F08D0001; Mon, 28 Mar 2022 18:10:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67A938D0002; Mon, 28 Mar 2022 18:10:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 59A6A8D0001 for ; Mon, 28 Mar 2022 18:10:43 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 30E0823CE5 for ; Mon, 28 Mar 2022 22:10:43 +0000 (UTC) X-FDA: 79295190366.13.69D05CA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id 05E41A003B for ; Mon, 28 Mar 2022 22:10:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8GkLc/s+XEtz/UORDgvxTa0KxKSEAfLI2AHFnWlv8Mk=; b=ICob3tApxQsmar5HbaaA3fVYUE Aa++An9QkojsDVrsh/htJ0+2v+LMyi9qn0y9676fOzkhDZyskgLhMGl218NEqnKk3pgDisRzyAagc Tar+Eyn01xVBFdR9TtK8Nh8xUCCRVsutxDXyLyROP7fJptrNfYl0hD8gUmxQWCywarq5M8YH2Gd1A uX6svXP8R5BDnGctjm3hgxNOqcFkseL6QO5HAY7ckxv6HoLX7U6faXR5McOyrRoqmg0hSFwyjPgHM d76QrrVArIoMYG1zpPg4LmHV7BzhXK+WnJWK3jTlIZC9ICgueWZK7m/8U3s2GFY1LfVLGv5ksk31b BZTPR92Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYxZK-00HJIv-IW; Mon, 28 Mar 2022 22:10:34 +0000 Date: Mon, 28 Mar 2022 23:10:34 +0100 From: Matthew Wilcox To: Hugh Dickins Cc: Stephen Rothwell , Andrew Morton , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, linux-mm@kvack.org Subject: Re: linux-next: build warnings after merge of the akpm-current tree Message-ID: References: <20220209170245.08968c92@canb.auug.org.au> <20220324182725.63a454e3@canb.auug.org.au> <224c2147-36fe-93ed-41a5-a4609b59b4a2@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <224c2147-36fe-93ed-41a5-a4609b59b4a2@google.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 05E41A003B X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ICob3tAp; dmarc=none; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: nqq49uwukqcr1jjicfibgebgqdxd9p4m X-HE-Tag: 1648505441-490000 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 28, 2022 at 12:54:14PM -0700, Hugh Dickins wrote: > On Thu, 24 Mar 2022, Stephen Rothwell wrote: > > > Hi all, > > > > On Wed, 9 Feb 2022 17:02:45 +1100 Stephen Rothwell wrote: > > > > > > After merging the akpm-current tree, today's linux-next build (htmldocs) > > > produced these warnings: > > > > > > include/linux/mm_types.h:272: warning: Function parameter or member '__filler' not described in 'folio' > > > include/linux/mm_types.h:272: warning: Function parameter or member 'mlock_count' not described in 'folio' > > > > > > Introduced by commit > > > > > > 60a5c5ab0ba7 ("mm/munlock: maintain page->mlock_count while unevictable") > > > > I am still getting these warnings. That commit is now > > > > 07ca76067308 ("mm/munlock: maintain page->mlock_count while unevictable") > > > > in Linus' tree :-( > > Sorry about that Stephen: back in Feb I expected Matthew to have strong > feelings about it, and it wouldn't have been helpful for me to mess it > around at that time. > > But I'll reply to this now with my suggested patch: which Matthew may > not like (he may consider it a retrograde step), but unless he NAKs it > and comes up with something we all like better, it should do for now. Sorry! I didn't see these emails back in February, or I would have fixed it up. I'm doing a build now, but it's a very slow process (and seems to have become single-threaded since the last time I ran it?) so it will be a little while before I can produce a patch. > I did try to 'make htmldocs' for the first time, but was put off by all > the new packages I was asked to install - not a good use of time. And > I'm so ignorant that I do not even know if "/* public: */" is a helpful > comment or a special annotation. Fortunately the documentation is actually documented: Documentation/doc-guide/kernel-doc.rst ''Structure, union, and enumeration documentation'' There are still many, many warnings when building the documentation, so don't feel particularly bad about this. I've tried to make it more obvious to non-doc-specialists by making W=1 emit warnings, but that only happens for .c files, not for .h files. As you say, the amount of tooling that needs to be installed to make htmldocs is intimidating.