From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52A60C433F5 for ; Thu, 7 Apr 2022 13:18:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4ACB6B0072; Thu, 7 Apr 2022 09:17:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFA5C6B0073; Thu, 7 Apr 2022 09:17:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC17C6B0074; Thu, 7 Apr 2022 09:17:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id AD7DD6B0072 for ; Thu, 7 Apr 2022 09:17:54 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5E8F7AD6D5 for ; Thu, 7 Apr 2022 13:17:44 +0000 (UTC) X-FDA: 79330135248.22.E3EC8E2 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf29.hostedemail.com (Postfix) with ESMTP id 59D52120008 for ; Thu, 7 Apr 2022 13:17:43 +0000 (UTC) Received: by mail-pl1-f179.google.com with SMTP id s11so4848487pla.8 for ; Thu, 07 Apr 2022 06:17:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xaFEdMdha8h42RWuuCwkqr0VCzd2sB+RNX9htkQaFF8=; b=Q4WySDtp3npUzYr7LCaMAKpcChHDjH5EtYUxBS5WjOSTpOpufANpns13Wj+Gr5G4fd 4PLyrEBAHnA8hP7wi5Fp4DWo3gcHnsvGkCyd9de+rZCEyRvhfh+9OyU43/6ViKKekO3t ACFLGS30cXfOQMNSCfPt8RKp3Z/31TLN7JJLVJHkGsuC8p+owLhPH1Jmuaowilivo7tK VJjHd2wg0+tNykHOV//TkfGAyTOj1fc/5aM8aqbyUgrgZDMQteysSqAFbFCCMB2llKt+ RIGkunul47ZCrDyTAnmjYJweTgzfRcLRQ0qiyCL6wyUIX0BAF95+9a+hsJhych8H1lSg ScGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xaFEdMdha8h42RWuuCwkqr0VCzd2sB+RNX9htkQaFF8=; b=UB+mDi87vQpPPBOSfm5WEQdt/z829EmSHaZCNyHN/jC5iYyWgCrk8XD3Z9w5KV67uB U/DTKkt5BxoTl+aijAC0szVTyosjzS3LlILSMQDIN9+fSOL40wDYsckzw+ZKoBRIhTCm p+E98+aeJ3deVt4xEDYGwqn8nzmSN/4gy6Jge6+fbOMVQkS5WfVAVOdBSWhjl3l0lOkX 0jwLRZPad4J9uGcW2c5EMoigzLIOBAhAQarx17pXVO3XMr2jib8UALsZ8k+pzqHpHTN8 tTsVEKFsOE7X1+ZJyKJ5O+3wAQu8RxX4/wzKhsiNgDfl91MdiS0cX638uEIBlv3C/qR/ k0NQ== X-Gm-Message-State: AOAM530NdPfANcHZlvI95+Tx4hw9xuMKQMfm2JAjUttG01PZ0dUuUlhg H/Yp0/7zb77rR+n07V87wy3vTQ== X-Google-Smtp-Source: ABdhPJzAIA6zaue5y4/HWCW1DduN5qnV98L+dQLWSOQjhzJalpap83t1+9GZcLK+U+u0+q/rNrvpXQ== X-Received: by 2002:a17:90b:4c12:b0:1c6:f450:729d with SMTP id na18-20020a17090b4c1200b001c6f450729dmr16146151pjb.190.1649337462055; Thu, 07 Apr 2022 06:17:42 -0700 (PDT) Received: from localhost ([139.177.225.245]) by smtp.gmail.com with ESMTPSA id d5-20020a056a0024c500b004fae56b2921sm22997159pfv.167.2022.04.07.06.17.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 06:17:41 -0700 (PDT) Date: Thu, 7 Apr 2022 21:17:38 +0800 From: Muchun Song To: Guo Zhengkui Cc: Andrew Morton , Shuah Khan , "open list:MEMORY MANAGEMENT" , "open list:KERNEL SELFTEST FRAMEWORK" , open list , zhengkui_guo@outlook.com Subject: Re: [PATCH] userfaultfd/selftests: use swap() instead of open coding it Message-ID: References: <20220407123141.4998-1-guozhengkui@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220407123141.4998-1-guozhengkui@vivo.com> X-Stat-Signature: pmzwmwm67bzdxfsp7gmm8x19mh8819ze Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=Q4WySDtp; spf=pass (imf29.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 59D52120008 X-HE-Tag: 1649337463-563613 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001388, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 07, 2022 at 08:31:41PM +0800, Guo Zhengkui wrote: > Address the following coccicheck warning: > > tools/testing/selftests/vm/userfaultfd.c:1536:21-22: WARNING opportunity > for swap(). > tools/testing/selftests/vm/userfaultfd.c:1540:33-34: WARNING opportunity > for swap(). > > by using swap() for the swapping of variable values and drop > `tmp_area` that is not needed any more. > > `swap()` macro in userfaultfd.c is introduced in commit 681696862bc18 > ("selftests: vm: remove dependecy from internal kernel macros") > > It has been tested with gcc (Debian 8.3.0-6) 8.3.0. > > Signed-off-by: Guo Zhengkui Reviewed-by: Muchun Song Thanks.