From: Michal Hocko <mhocko@suse.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
"Andrew Morton" <akpm@linux-foundation.org>,
stable@vger.kernel.org,
"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
"Mel Gorman" <mgorman@suse.de>
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()
Date: Thu, 7 Apr 2022 13:07:04 +0200 [thread overview]
Message-ID: <Yk7F2KzRrhLjYw4Z@dhcp22.suse.cz> (raw)
In-Reply-To: <f08c1493-9238-0009-56b4-dc0ab3571b33@suse.com>
On Thu 07-04-22 12:45:41, Juergen Gross wrote:
> On 07.04.22 12:34, Michal Hocko wrote:
> > Ccing Mel
> >
> > On Thu 07-04-22 11:32:21, Juergen Gross wrote:
> > > Since commit 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist
> > > initialization") only zones with free memory are included in a built
> > > zonelist. This is problematic when e.g. all memory of a zone has been
> > > ballooned out.
> >
> > What is the actual problem there?
>
> When running as Xen guest new hotplugged memory will not be onlined
> automatically, but only on special request. This is done in order to
> support adding e.g. the possibility to use another GB of memory, while
> adding only a part of that memory initially.
>
> In case adding that memory is populating a new zone, the page allocator
> won't be able to use this memory when it is onlined, as the zone wasn't
> added to the zonelist, due to managed_zone() returning 0.
How is that memory onlined? Because "regular" onlining (online_pages())
does rebuild zonelists if their zone hasn't been populated before.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2022-04-07 11:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 9:32 Juergen Gross
2022-04-07 9:46 ` David Hildenbrand
2022-04-07 10:06 ` Juergen Gross
2022-04-08 23:21 ` Wei Yang
2022-04-07 10:34 ` Michal Hocko
2022-04-07 10:45 ` Juergen Gross
2022-04-07 11:07 ` Michal Hocko [this message]
2022-04-07 11:17 ` Juergen Gross
2022-04-07 11:40 ` Michal Hocko
2022-04-07 11:48 ` Michal Hocko
2022-04-07 11:58 ` David Hildenbrand
2022-04-07 12:04 ` Michal Hocko
2022-04-07 12:12 ` David Hildenbrand
2022-04-07 13:23 ` Michal Hocko
2022-04-07 12:32 ` Mel Gorman
2022-04-07 12:49 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yk7F2KzRrhLjYw4Z@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marmarek@invisiblethingslab.com \
--cc=mgorman@suse.de \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox