From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51B4FC433EF for ; Thu, 7 Apr 2022 14:48:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFACF6B0072; Thu, 7 Apr 2022 10:47:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B83816B0073; Thu, 7 Apr 2022 10:47:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D68A6B0074; Thu, 7 Apr 2022 10:47:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0123.hostedemail.com [216.40.44.123]) by kanga.kvack.org (Postfix) with ESMTP id 88E276B0072 for ; Thu, 7 Apr 2022 10:47:50 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 429FAAB9D8 for ; Thu, 7 Apr 2022 14:47:40 +0000 (UTC) X-FDA: 79330361880.28.EC66A02 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf27.hostedemail.com (Postfix) with ESMTP id 8AF9E40009 for ; Thu, 7 Apr 2022 14:47:39 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 43689212CA; Thu, 7 Apr 2022 14:47:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1649342858; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mEpOOttjvoUOVasmXAsJpY6Q5iNZbgHNH+XLnQf/mr0=; b=mn3LNRAvq1DPia5c5FhuVf/A2AGoYxSlFq/woldm/j5+8408QUkjCb1rmYaGqfI/hTv+oD e6BAwOJ8bfshnxTA67lerKJ8kIijBQc01D0HPph+lHYRPjBfmpthPdgMdBKmnGlWyGGV67 awYGzqweZ/Lv2P2fPvVfVD5Nq8w4WSw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1649342858; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mEpOOttjvoUOVasmXAsJpY6Q5iNZbgHNH+XLnQf/mr0=; b=CtvFw589hGQJBghYO6rW1rTfOAhb69sM87A0i3sS1K3CJVWP1zZfmiBnNsP/Ie5XD+Nme3 +f379Iw8YGylT5Cw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3258713485; Thu, 7 Apr 2022 14:47:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id f3FBDIr5TmJaXAAAMHmgww (envelope-from ); Thu, 07 Apr 2022 14:47:38 +0000 Date: Thu, 7 Apr 2022 16:47:36 +0200 From: Borislav Petkov To: Thomas Gleixner Cc: Brijesh Singh , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Borislav Petkov , Michael Roth , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , "Dr . David Alan Gilbert" , brijesh.ksingh@gmail.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH v12 29/46] x86/boot: Add Confidential Computing type to setup_data Message-ID: References: <20220307213356.2797205-1-brijesh.singh@amd.com> <20220307213356.2797205-30-brijesh.singh@amd.com> <87v8vlzz8x.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87v8vlzz8x.ffs@tglx> X-Rspam-User: X-Stat-Signature: 7khk644ugbhaeoy8wninwiiqar93iym9 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mn3LNRAv; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=CtvFw589; spf=pass (imf27.hostedemail.com: domain of bp@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=bp@suse.de; dmarc=pass (policy=none) header.from=suse.de X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 8AF9E40009 X-HE-Tag: 1649342859-476331 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 06, 2022 at 11:19:10PM +0200, Thomas Gleixner wrote: > On Mon, Mar 07 2022 at 15:33, Brijesh Singh wrote: > > =20 > > +/* > > + * AMD SEV Confidential computing blob structure. The structure is > > + * defined in OVMF UEFI firmware header: > > + * https://github.com/tianocore/edk2/blob/master/OvmfPkg/Include/Gui= d/ConfidentialComputingSevSnpBlob.h > > + */ > > +#define CC_BLOB_SEV_HDR_MAGIC 0x45444d41 > > +struct cc_blob_sev_info { > > + u32 magic; > > + u16 version; > > + u16 reserved; > > + u64 secrets_phys; > > + u32 secrets_len; > > + u32 rsvd1; > > + u64 cpuid_phys; > > + u32 cpuid_len; > > + u32 rsvd2; > > +}; >=20 > Shouldn't this be packed? Done. Thx. --=20 Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH, GF: Ivo Totev, HRB 36809, AG N=C3=BC= rnberg