From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9F00C4332F for ; Wed, 6 Apr 2022 15:08:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE0686B0071; Wed, 6 Apr 2022 11:08:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C90336B0073; Wed, 6 Apr 2022 11:08:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B30686B0074; Wed, 6 Apr 2022 11:08:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id A58216B0071 for ; Wed, 6 Apr 2022 11:08:45 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 61EC98200D for ; Wed, 6 Apr 2022 15:08:35 +0000 (UTC) X-FDA: 79326785790.03.9591972 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 47CDBA0047 for ; Wed, 6 Apr 2022 15:08:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649257713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2h2JRMMUQQ1WMvyGWASFIFHk1H9/kbrYdek1XhlGKsQ=; b=SrXwX7cz1ZgeHSpuD7Sy9SSudoq0YLdMh2yeYr8mQzazYyfsSCpzPJHIrVt8Z+KVEVa17Z ExOddMHxJErrqFyKV6quXGkB9FTxd/E9G3WCAolmkZjdJASPwzVggfoPMH7kObUPUoJL0L D9wg3HhYA2fUVltJmZxI7BRUcE4YdWA= Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-125-0VhqhkGFMtiqEWCT1O1PPQ-1; Wed, 06 Apr 2022 11:02:16 -0400 X-MC-Unique: 0VhqhkGFMtiqEWCT1O1PPQ-1 Received: by mail-io1-f72.google.com with SMTP id d19-20020a0566022bf300b00645eba5c992so1774375ioy.4 for ; Wed, 06 Apr 2022 08:02:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/3Bz+6mxeokIYB8L/BSNNV23dZJu+F2jesvn+3ntwnM=; b=sXUguDGFo+q+Mw9Gm8SCyNHQtsDnKEh59AwcVEaW50tYCdBV5UCnevX8DW8MmctY+S 0jDci8dYyJJcLeDVxQCHK4VvxrnFf94ncA4/DfbXkJ/KYo4v68GME8MT9b6OrkfOAO3T rTbOq3I55lCoJQuSfDQ+wyAqs9sXLXSq7XZr+b58wRgnwHAFak2NdfXY3DOQnQbE/fgd 7IeiBZ7+dfcY2dycailbZhhBcVhoAN1WdrqCh9DZ3aVJMvPWKilHz48TCOSfvAQoA/i+ k5BNeJ9oUlBuGT8KxyLo2xl9YFzB9nDjYXX2OUwhRAfM5ap//8/L+ZyrnELZPl1Id8Y6 jvsw== X-Gm-Message-State: AOAM532YDJ00sDytQ+l6vSNSwgLktVtaxDKGCMvTiRz+1c6qm4Wy68Xn sSd0Q5PO/W+5dD8X7KQ8BLeN+5Y0VCqH48P8gGdbQh+htddEf4ipslHwsCDMxpK0bdwQ8BYZjo6 tWjSZIdL3bI8= X-Received: by 2002:a6b:d10c:0:b0:641:63b2:9ef8 with SMTP id l12-20020a6bd10c000000b0064163b29ef8mr4264774iob.135.1649257335226; Wed, 06 Apr 2022 08:02:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwouWP4dTVYHsqZxyr/OP0EkEm2M9n4n0oS+NpczhwwZJSAFO2isyLss0cd8b+zjJfVkwDOPw== X-Received: by 2002:a6b:d10c:0:b0:641:63b2:9ef8 with SMTP id l12-20020a6bd10c000000b0064163b29ef8mr4264750iob.135.1649257334912; Wed, 06 Apr 2022 08:02:14 -0700 (PDT) Received: from xz-m1.local (cpec09435e3e0ee-cmc09435e3e0ec.cpe.net.cable.rogers.com. [99.241.198.116]) by smtp.gmail.com with ESMTPSA id y3-20020a92c983000000b002c7dce8329fsm9394700iln.72.2022.04.06.08.02.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 08:02:14 -0700 (PDT) Date: Wed, 6 Apr 2022 11:02:12 -0400 From: Peter Xu To: kernel test robot Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kbuild-all@lists.01.org, Mike Kravetz , Nadav Amit , Matthew Wilcox , Mike Rapoport , David Hildenbrand , Hugh Dickins , Jerome Glisse , "Kirill A . Shutemov" , Andrea Arcangeli , Andrew Morton , Axel Rasmussen , Alistair Popple Subject: Re: [PATCH v8 15/23] mm/hugetlb: Handle pte markers in page faults Message-ID: References: <20220405014909.14761-1-peterx@redhat.com> <202204062154.2txNJyaf-lkp@intel.com> MIME-Version: 1.0 In-Reply-To: <202204062154.2txNJyaf-lkp@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="gQDMqriStFwDEZjG" Content-Disposition: inline X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 47CDBA0047 X-Stat-Signature: wzrrru14pdx4qexp3aoeoa8gtgdnrfyo X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SrXwX7cz; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf15.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com X-HE-Tag: 1649257714-995531 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --gQDMqriStFwDEZjG Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Wed, Apr 06, 2022 at 09:37:00PM +0800, kernel test robot wrote: > Hi Peter, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on hnaz-mm/master] > [cannot apply to arnd-asm-generic/master linus/master linux/master v5.18-rc1 next-20220406] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/intel-lab-lkp/linux/commits/Peter-Xu/userfaultfd-wp-Support-shmem-and-hugetlbfs/20220405-100136 > base: https://github.com/hnaz/linux-mm master > config: s390-randconfig-r044-20220406 (https://download.01.org/0day-ci/archive/20220406/202204062154.2txNJyaf-lkp@intel.com/config) > compiler: s390-linux-gcc (GCC) 11.2.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/e7e7aaec811e2817cd169f0cc1d8f81bdf1f05c3 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Peter-Xu/userfaultfd-wp-Support-shmem-and-hugetlbfs/20220405-100136 > git checkout e7e7aaec811e2817cd169f0cc1d8f81bdf1f05c3 > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > mm/hugetlb.c: In function 'hugetlb_fault': > >> mm/hugetlb.c:5678:13: error: implicit declaration of function 'huge_pte_none_mostly'; did you mean 'pte_none_mostly'? [-Werror=implicit-function-declaration] > 5678 | if (huge_pte_none_mostly(entry)) { > | ^~~~~~~~~~~~~~~~~~~~ > | pte_none_mostly > cc1: some warnings being treated as errors Ah, the s390 stub was forgotten again, sorry. I hope someday s390 will start to include asm-generic/hugetlb.h like all the rest archs, because that's really from the gut feeling of how it should happen.. or the dir should be renamed to asm-generic-without-s390/. :( An expected fix patch attached (to be squashed into patch "mm: Introduce PTE_MARKER swap entry"). Thanks, -- Peter Xu --gQDMqriStFwDEZjG Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0001-fixup-mm-Introduce-PTE_MARKER-swap-entry.patch" >From 8b84d7f6b86c30623208eff386b4f5169f1cb0db Mon Sep 17 00:00:00 2001 From: Peter Xu Date: Wed, 6 Apr 2022 10:55:55 -0400 Subject: [PATCH] fixup! mm: Introduce PTE_MARKER swap entry Signed-off-by: Peter Xu --- arch/s390/include/asm/hugetlb.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/s390/include/asm/hugetlb.h b/arch/s390/include/asm/hugetlb.h index be99eda87f4d..32c3fd6e878e 100644 --- a/arch/s390/include/asm/hugetlb.h +++ b/arch/s390/include/asm/hugetlb.h @@ -85,6 +85,11 @@ static inline int huge_pte_none(pte_t pte) return pte_none(pte); } +static inline int huge_pte_none_mostly(pte_t pte) +{ + return huge_pte_none(pte); +} + static inline int huge_pte_write(pte_t pte) { return pte_write(pte); -- 2.32.0 --gQDMqriStFwDEZjG--