From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8626CC433EF for ; Fri, 8 Apr 2022 06:42:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1FA56B0071; Fri, 8 Apr 2022 02:42:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED00E6B0072; Fri, 8 Apr 2022 02:42:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D96D16B0074; Fri, 8 Apr 2022 02:42:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0157.hostedemail.com [216.40.44.157]) by kanga.kvack.org (Postfix) with ESMTP id CA3596B0071 for ; Fri, 8 Apr 2022 02:42:25 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8AC1082F3BE8 for ; Fri, 8 Apr 2022 06:42:25 +0000 (UTC) X-FDA: 79332767850.25.2ABD7BE Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf17.hostedemail.com (Postfix) with ESMTP id 0969D40002 for ; Fri, 8 Apr 2022 06:42:24 +0000 (UTC) Received: by mail-pl1-f176.google.com with SMTP id y6so7096140plg.2 for ; Thu, 07 Apr 2022 23:42:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pYAWmA2mzvjlynkITTRP/QBtHX3DhppNiVnqizFawyk=; b=m3eYQ2SnsKAcXforZE0s4H1JXIupwn57zG7A5EQuiAUeTmfB/YyOuJHhZ9yQ22aUF0 3kfjqC5krkpaxIthl7/vQy19PpxneYBHPRMJcaxknoh+6MdmvYpx7Lhy3ta5XYHHXjc/ AKtVXXTuaCKISLYE7p7qwwYQ5kSIJn7feeTslmOfyFWPTyt46OPW/mQnvQi4a9RL+eeM uNX9FazyIfGRhHoa3yBGa8oj3ZUS05YB0SXqa1vcQp1todBt5YDNWmIBeUUrMXW9s3tS 3BdsLGxJt/ZWuHu2bI3uahgcfBUNOv7NKZmsE5JcQmrJ2Agnx47JhHBJb06JYarwEwUJ q78w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pYAWmA2mzvjlynkITTRP/QBtHX3DhppNiVnqizFawyk=; b=xb6vu57ncmaq0MLh0XH2UAdRUMSevO6UxSTydAQKOmVQMjI6NjIITWWH7Wte3RG690 C3ppTnIyAX4GSOLyUO1KCRkeZXIwANCHYRUN3Hqnnw0iBLwQP1wFB/myHegc3kPPtK9O 7I8CWV7IzohfQF4k3WNtdmHlAB63LfX+nUXBpRhBvq36YaVFjE3EbGfszy9yJX8aMS3p y+CXe1ZnhAlf6UMV7aWgLCEHA1sOEWr8K3aYecIgNlr1eylOGWXkJhQrEXC/zcq4dHDu ibQJyyg7TjgDgqgOxeXSlGrbBkEPi/X896pyHiiI4msHe1OtkTwn2Qe2x88HKyjsgB6B KXvg== X-Gm-Message-State: AOAM531w61qzMprBBqArkPrpPNJH7m3BfIQtcyXKVubb0td3qsLIqb0y F/D3A5PuIa9NgLQW2POjaVZbnPhuFvymjQ== X-Google-Smtp-Source: ABdhPJwzWfhiEuvayiUnpNnk4zCnrgrOkuebnQasPetk1mTi8/i/6CSqaM+0Z7ybryAGQdYAW9vLBA== X-Received: by 2002:a17:903:2446:b0:154:3bb0:7ba0 with SMTP id l6-20020a170903244600b001543bb07ba0mr17352444pls.38.1649400143908; Thu, 07 Apr 2022 23:42:23 -0700 (PDT) Received: from hyeyoo ([114.29.24.243]) by smtp.gmail.com with ESMTPSA id y24-20020a056a00181800b004fac7d687easm25036917pfa.66.2022.04.07.23.42.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 23:42:20 -0700 (PDT) Date: Fri, 8 Apr 2022 15:42:13 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Catalin Marinas Cc: Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/10] mm/slab: Decouple ARCH_KMALLOC_MINALIGN from ARCH_DMA_MINALIGN Message-ID: References: <20220405135758.774016-1-catalin.marinas@arm.com> <20220405135758.774016-2-catalin.marinas@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220405135758.774016-2-catalin.marinas@arm.com> Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=m3eYQ2Sn; spf=pass (imf17.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0969D40002 X-Stat-Signature: sqk7p99gjiccfeeqd1k7mb3fnm3r6sa3 X-HE-Tag: 1649400144-181871 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 05, 2022 at 02:57:49PM +0100, Catalin Marinas wrote: > In preparation for supporting a dynamic kmalloc() minimum alignment, > allow architectures to define ARCH_KMALLOC_MINALIGN independently of > ARCH_DMA_MINALIGN. In addition, always define ARCH_DMA_MINALIGN even if > an architecture does not override it. > > After this patch, ARCH_DMA_MINALIGN is expected to be used in static > alignment annotations and defined by an architecture to be the maximum > alignment for all supported configurations/SoCs in a single Image. > ARCH_KMALLOC_MINALIGN, if different, is the minimum alignment guaranteed > by kmalloc(). > > Signed-off-by: Catalin Marinas > Cc: Andrew Morton > --- > include/linux/slab.h | 23 ++++++++++++++++++----- > 1 file changed, 18 insertions(+), 5 deletions(-) > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 373b3ef99f4e..d58211bdeceb 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -187,17 +187,30 @@ bool kmem_valid_obj(void *object); > void kmem_dump_obj(void *object); > #endif > > +/* > + * slob does not support independent control of ARCH_KMALLOC_MINALIGN and > + * ARCH_DMA_MINALIGN. > + */ > +#ifdef CONFIG_SLOB > +#undef ARCH_KMALLOC_MINALIGN > +#endif I think you should replace ARCH_KMALLOC_MINALIGN with ARCH_DMA_MINALIGN in mm/slob.c too? Or detect minimum kmalloc alignment in runtime like SLAB/SLUB? current code seem to break with SLOB on machines that has 128 byte cache lines because ARCH_KMALLOC_MINALIGN is 64? > + > /* > * Some archs want to perform DMA into kmalloc caches and need a guaranteed > * alignment larger than the alignment of a 64-bit integer. > - * Setting ARCH_KMALLOC_MINALIGN in arch headers allows that. > + * Setting ARCH_DMA_MINALIGN in arch headers allows that. > */ > -#if defined(ARCH_DMA_MINALIGN) && ARCH_DMA_MINALIGN > 8 > +#ifndef ARCH_DMA_MINALIGN > +#define ARCH_DMA_MINALIGN __alignof__(unsigned long long) > +#elif ARCH_DMA_MINALIGN > 8 && !defined(ARCH_KMALLOC_MINALIGN) > #define ARCH_KMALLOC_MINALIGN ARCH_DMA_MINALIGN > -#define KMALLOC_MIN_SIZE ARCH_DMA_MINALIGN > -#define KMALLOC_SHIFT_LOW ilog2(ARCH_DMA_MINALIGN) > -#else > +#endif > + > +#ifndef ARCH_KMALLOC_MINALIGN > #define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long long) > +#else > +#define KMALLOC_MIN_SIZE ARCH_KMALLOC_MINALIGN > +#define KMALLOC_SHIFT_LOW ilog2(KMALLOC_MIN_SIZE) > #endif > > /* > -- Thanks, Hyeonggon