From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5EDBC4332F for ; Thu, 24 Mar 2022 12:45:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EAC96B0072; Thu, 24 Mar 2022 08:45:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 572866B0073; Thu, 24 Mar 2022 08:45:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 412CB6B0074; Thu, 24 Mar 2022 08:45:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0237.hostedemail.com [216.40.44.237]) by kanga.kvack.org (Postfix) with ESMTP id 2E5786B0072 for ; Thu, 24 Mar 2022 08:45:58 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DE1FF1828BF13 for ; Thu, 24 Mar 2022 12:45:57 +0000 (UTC) X-FDA: 79279251954.16.3F1E93D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 1750640018 for ; Thu, 24 Mar 2022 12:45:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SEe56zLZugRIS2AzzpTha7A/J25pZy6DnvCcHtv9Yo4=; b=aEM1Gvinp6XNa6RFWnZa9IMOug 7zBnJI8RNDVO0ZpsvroUrW9Id0dtanscK1wFYzZkJhNJqZkOLV8LAzenD1nOADShEJOGuTWJuVr9S gWm4FCJBFeQYLZnJWP60YRGG4DQHCHesMSS9oYyUFvAYF3GoTAzY6LMUBVZdVq8aMzSFPzal046WQ aX1RaMhurNYhvJrL/FvvO4fVeZ7pGzsRMGijSg0pAfVH9KivcSEnXWxDbViWpqpzSvSxboS741BmB seVcCxjlLoNkA50vDuZGj8LIohCxzWsYsBZ8VxsKjAGqhJ7vm/HNw2UG67a8Ov0LEINRWxED+EAMB aja8aaXg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXMqF-00DRPE-99; Thu, 24 Mar 2022 12:45:27 +0000 Date: Thu, 24 Mar 2022 12:45:27 +0000 From: Matthew Wilcox To: cgel.zte@gmail.com Cc: akpm@linux-foundation.org, david@redhat.com, yang.yang29@zte.com.cn, ran.xiaokai@zte.com.cn, yang.shi@linux.alibaba.com, dave.hansen@linux.intel.com, minchan@kernel.org, saravanand@fb.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, xu xin Subject: Re: [PATCH v3] mm/vmstat: add events for ksm cow Message-ID: References: <20220324104332.2350482-1-yang.yang29@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220324104332.2350482-1-yang.yang29@zte.com.cn> X-Stat-Signature: jbidg4nfknn6kg59mzyeajecwhd3xm9t Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=aEM1Gvin; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1750640018 X-HE-Tag: 1648125956-579848 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 24, 2022 at 10:43:33AM +0000, cgel.zte@gmail.com wrote: > +++ b/include/linux/vm_event_item.h > @@ -131,6 +131,7 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > SWAP_RA_HIT, > #ifdef CONFIG_KSM > KSM_SWPIN_COPY, > + COW_KSM, Shouldn't we call this KSM_COW? > +++ b/mm/vmstat.c > @@ -1390,6 +1390,7 @@ const char * const vmstat_text[] = { > "swap_ra_hit", > #ifdef CONFIG_KSM > "ksm_swpin_copy", > + "cow_ksm", ... and this "ksm_cow"?