From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18F00C433EF for ; Thu, 24 Mar 2022 01:48:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D5F06B0072; Wed, 23 Mar 2022 21:48:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 785DD6B0073; Wed, 23 Mar 2022 21:48:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69CAE6B0074; Wed, 23 Mar 2022 21:48:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 5B51E6B0072 for ; Wed, 23 Mar 2022 21:48:26 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 2A25A81E43 for ; Thu, 24 Mar 2022 01:48:26 +0000 (UTC) X-FDA: 79277595012.03.C4219F7 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by imf23.hostedemail.com (Postfix) with ESMTP id A8B6314002E for ; Thu, 24 Mar 2022 01:48:25 +0000 (UTC) Received: from cwcc.thunk.org (pool-108-7-220-252.bstnma.fios.verizon.net [108.7.220.252]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 22O1lwh9019980 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Mar 2022 21:47:59 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 71AB615C0038; Wed, 23 Mar 2022 21:47:58 -0400 (EDT) Date: Wed, 23 Mar 2022 21:47:58 -0400 From: "Theodore Ts'o" To: Yang Shi Cc: vbabka@suse.cz, kirill.shutemov@linux.intel.com, linmiaohe@huawei.com, songliubraving@fb.com, riel@surriel.com, willy@infradead.org, ziy@nvidia.com, akpm@linux-foundation.org, adilger.kernel@dilger.ca, darrick.wong@oracle.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v2 PATCH 0/8] Make khugepaged collapse readonly FS THP more consistent Message-ID: References: <20220317234827.447799-1-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220317234827.447799-1-shy828301@gmail.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A8B6314002E X-Stat-Signature: ej7rja5x3re74745e1kqxdiwwqzzkmo6 X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=mit.edu (policy=none); spf=none (imf23.hostedemail.com: domain of tytso@mit.edu has no SPF policy when checking 18.9.28.11) smtp.mailfrom=tytso@mit.edu X-HE-Tag: 1648086505-177498 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 17, 2022 at 04:48:19PM -0700, Yang Shi wrote: > > The patch 1 ~ 7 are minor bug fixes, clean up and preparation patches. > The patch 8 converts ext4 and xfs. We may need convert more filesystems, > but I'd like to hear some comments before doing that. Adding a hard-coded call to khugepage_enter_file() in ext4 and xfs, and potentially, each file system, seems kludgy as all heck. Is there any reason not to simply call it in the mm code which calls f_op->mmap()? - Ted