From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04C80C433F5 for ; Wed, 23 Mar 2022 18:30:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 564076B007D; Wed, 23 Mar 2022 14:30:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EB658D0001; Wed, 23 Mar 2022 14:30:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38C106B0080; Wed, 23 Mar 2022 14:30:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0111.hostedemail.com [216.40.44.111]) by kanga.kvack.org (Postfix) with ESMTP id 245216B007D for ; Wed, 23 Mar 2022 14:30:51 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C915018238CDC for ; Wed, 23 Mar 2022 18:30:50 +0000 (UTC) X-FDA: 79276492260.16.FA022CC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 113DA100027 for ; Wed, 23 Mar 2022 18:30:49 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4E26E6149D; Wed, 23 Mar 2022 18:30:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54F54C340EE; Wed, 23 Mar 2022 18:30:47 +0000 (UTC) Date: Wed, 23 Mar 2022 18:30:43 +0000 From: Catalin Marinas To: Steve Capper Cc: linux-mm@kvack.org, David Hildenbrand , Anshuman Khandual , Will Deacon , Peter Zijlstra Subject: Re: [PATCH] tlb: hugetlb: Add arm64 contiguous hint awareness Message-ID: References: <20220323165218.35499-1-steve.capper@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220323165218.35499-1-steve.capper@arm.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 113DA100027 X-Stat-Signature: ydsqmp3uzyqrxqiesg41p7c6bur7whoi Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) X-Rspam-User: X-HE-Tag: 1648060249-949121 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 23, 2022 at 04:52:18PM +0000, Steve Capper wrote: > tlb_remove_huge_tlb_entry only considers PMD_SIZE and PUD_SIZE when > updating the mmu_gather structure. > > Unfortunately on arm64 there are two additional huge page sizes that > need to be covered: CONT_PTE_SIZE and CONT_PMD_SIZE. Where an end-user > attempts to employ contiguous huge pages, a VM_BUG_ON can be experienced > due to the fact that the tlb structure hasn't been correctly updated by > the relevant tlb_flush_p.._range() call from tlb_remove_huge_tlb_entry. > > This patch adds the ability to define per-arch implementations of > tlb_remove_huge_tlb_entry and supplies an arm64 implementation that > covers the contiguous hint sizes. > > Reported-by: David Hildenbrand > Cc: Anshuman Khandual > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Peter Zijlstra (Intel) > Link: https://lore.kernel.org/linux-mm/811c5c8e-b3a2-85d2-049c-717f17c3a03a@redhat.com/ > Signed-off-by: Steve Capper Reviewed-by: Catalin Marinas