From: Christoph Hellwig <hch@infradead.org>
To: Muchun Song <songmuchun@bytedance.com>
Cc: dan.j.williams@intel.com, willy@infradead.org, jack@suse.cz,
viro@zeniv.linux.org.uk, akpm@linux-foundation.org,
apopple@nvidia.com, shy828301@gmail.com, rcampbell@nvidia.com,
hughd@google.com, xiyuyang19@fudan.edu.cn,
kirill.shutemov@linux.intel.com, zwisler@kernel.org,
hch@infradead.org, linux-fsdevel@vger.kernel.org,
nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, duanxiongchun@bytedance.com,
smuchun@gmail.com
Subject: Re: [PATCH v5 2/6] dax: fix cache flush on PMD-mapped pages
Date: Tue, 22 Mar 2022 01:34:24 -0700 [thread overview]
Message-ID: <YjmKEEK3fz8a93iN@infradead.org> (raw)
In-Reply-To: <20220318074529.5261-3-songmuchun@bytedance.com>
On Fri, Mar 18, 2022 at 03:45:25PM +0800, Muchun Song wrote:
> The flush_cache_page() only remove a PAGE_SIZE sized range from the cache.
> However, it does not cover the full pages in a THP except a head page.
> Replace it with flush_cache_range() to fix this issue. This is just a
> documentation issue with the respect to properly documenting the expected
> usage of cache flushing before modifying the pmd. However, in practice
> this is not a problem due to the fact that DAX is not available on
> architectures with virtually indexed caches per:
>
> commit d92576f1167c ("dax: does not work correctly with virtual aliasing caches")
>
> Fixes: f729c8c9b24f ("dax: wrprotect pmd_t in dax_mapping_entry_mkclean")
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-03-22 8:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 7:45 [PATCH v5 0/6] Fix some bugs related to ramp and dax Muchun Song
2022-03-18 7:45 ` [PATCH v5 1/6] mm: rmap: fix cache flush on THP pages Muchun Song
2022-03-22 8:34 ` Christoph Hellwig
2022-03-18 7:45 ` [PATCH v5 2/6] dax: fix cache flush on PMD-mapped pages Muchun Song
2022-03-22 8:34 ` Christoph Hellwig [this message]
2022-03-18 7:45 ` [PATCH v5 3/6] mm: rmap: introduce pfn_mkclean_range() to cleans PTEs Muchun Song
2022-03-18 7:45 ` [PATCH v5 4/6] mm: pvmw: add support for walking devmap pages Muchun Song
2022-03-18 7:45 ` [PATCH v5 5/6] dax: fix missing writeprotect the pte entry Muchun Song
2022-03-22 8:37 ` Christoph Hellwig
2022-03-22 8:46 ` Muchun Song
2022-03-18 7:45 ` [PATCH v5 6/6] mm: simplify follow_invalidate_pte() Muchun Song
2022-03-22 8:35 ` Christoph Hellwig
2022-03-31 15:55 ` [PATCH v5 0/6] Fix some bugs related to ramp and dax Qian Cai
2022-03-31 22:36 ` Andrew Morton
2022-03-31 22:48 ` Stephen Rothwell
2022-04-01 3:44 ` Muchun Song
2022-04-01 8:50 ` Muchun Song
2022-04-01 11:07 ` Qian Cai
2022-04-02 15:22 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjmKEEK3fz8a93iN@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=duanxiongchun@bytedance.com \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nvdimm@lists.linux.dev \
--cc=rcampbell@nvidia.com \
--cc=shy828301@gmail.com \
--cc=smuchun@gmail.com \
--cc=songmuchun@bytedance.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=xiyuyang19@fudan.edu.cn \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox