From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87303C433EF for ; Mon, 21 Mar 2022 19:54:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A9056B0072; Mon, 21 Mar 2022 15:54:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 857A76B0073; Mon, 21 Mar 2022 15:54:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71FDA6B0074; Mon, 21 Mar 2022 15:54:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 641E66B0072 for ; Mon, 21 Mar 2022 15:54:47 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 3A5FC60C9A for ; Mon, 21 Mar 2022 19:54:47 +0000 (UTC) X-FDA: 79269446214.10.DDED424 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id B53661C0031 for ; Mon, 21 Mar 2022 19:54:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4efTTqCS4Gsyb7wXaU8yL8zAGuclTlr6Cip6vqeSx5U=; b=gGjMpvSX+0ScawY3AAK5s8QnbO XilmRzJ+bqBsjUujrCWbfeV/tiRX+pQZDKbIS1SYRtDXXz1K9KLWQrCrfPxGmLQfFztXcAsXJ2Ddo l4tFcS3eTzqbtxZbVV5mTyle4MnmSMieKmIpHog/hTDlWj7SWmzHTxHQWMzK7iDKSGEKFuCuCF/9W coeGAeogiJmc3cJpJwW11rZXRiUcEkhs/lgHGb9qR0vtxf8I6ssv8JvulnzZxoy9KoA+SjsZE3S7Q 24osUQanD2wp6GrgKEPW9Zicp2W4mjDyhuUcBHe/T+iGNKsM6u29kq3/ct+LGca1//oM3Lch994Ro fcXZH5cw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWO6v-00AtdF-9P; Mon, 21 Mar 2022 19:54:37 +0000 Date: Mon, 21 Mar 2022 19:54:37 +0000 From: Matthew Wilcox To: Zi Yan Cc: Roman Gushchin , linux-mm@kvack.org, Shuah Khan , Yang Shi , Miaohe Lin , Hugh Dickins , "Kirill A . Shutemov" , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [RFC PATCH 1/5] mm: memcg: make memcg huge page split support any order split. Message-ID: References: <20220321142128.2471199-1-zi.yan@sent.com> <20220321142128.2471199-2-zi.yan@sent.com> <0001CABA-9436-4EFF-9C7F-F67300D09DA1@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0001CABA-9436-4EFF-9C7F-F67300D09DA1@nvidia.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B53661C0031 X-Stat-Signature: 7hjmxu8px8wx1o9eeiw3y3ixex8nois9 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=gGjMpvSX; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1647892485-824308 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 21, 2022 at 03:07:46PM -0400, Zi Yan wrote: > Yes. Will change it to new_nr to be consistent. uh, you're going to call ilog2? I think this would look less inconsistent if 'nr' were an unsigned long (how long until we need 16GB pages? Think PPC already supports those)