From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2E71C433F5 for ; Mon, 21 Mar 2022 18:57:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA8CF6B0071; Mon, 21 Mar 2022 14:57:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D56716B0073; Mon, 21 Mar 2022 14:57:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C452B6B0074; Mon, 21 Mar 2022 14:57:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0172.hostedemail.com [216.40.44.172]) by kanga.kvack.org (Postfix) with ESMTP id B5C7D6B0071 for ; Mon, 21 Mar 2022 14:57:22 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 40109A3248 for ; Mon, 21 Mar 2022 18:57:22 +0000 (UTC) X-FDA: 79269301524.26.FA43E1C Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by imf31.hostedemail.com (Postfix) with ESMTP id A3E1220010 for ; Mon, 21 Mar 2022 18:57:21 +0000 (UTC) Date: Mon, 21 Mar 2022 11:57:11 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1647889038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/f628apkMpQsjSicVFzN0gWVenPYv3XtQ9ROsVjz1zw=; b=NLKvTkWVtIcr90tfxAO2XU/dNqfJbG6SpakXGsYu4nUm1t+IsyQ57Teq3ybpNZQL1sahsQ CbjbE+jOO3LR4Tu4y76Yxkw+BX+9uIhZFxOV6+BGKrEJiE7ReVDr5g7ZEjQGn7ivkPzlYF G7Y2bm7vKrmhEixspnA5N6snIVmDdDE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Zi Yan Cc: Matthew Wilcox , linux-mm@kvack.org, Shuah Khan , Yang Shi , Miaohe Lin , Hugh Dickins , "Kirill A . Shutemov" , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [RFC PATCH 1/5] mm: memcg: make memcg huge page split support any order split. Message-ID: References: <20220321142128.2471199-1-zi.yan@sent.com> <20220321142128.2471199-2-zi.yan@sent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220321142128.2471199-2-zi.yan@sent.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A3E1220010 X-Stat-Signature: fqeicqrkffe8983q13crsdbbewz1bg19 X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=NLKvTkWV; spf=pass (imf31.hostedemail.com: domain of roman.gushchin@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-HE-Tag: 1647889041-534760 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 21, 2022 at 10:21:24AM -0400, Zi Yan wrote: > From: Zi Yan > > It sets memcg information for the pages after the split. A new parameter > new_order is added to tell the new page order, always 0 for now. It > prepares for upcoming changes to support split huge page to any lower > order. > > Signed-off-by: Zi Yan > --- > include/linux/memcontrol.h | 2 +- > mm/huge_memory.c | 2 +- > mm/memcontrol.c | 10 +++++----- > mm/page_alloc.c | 2 +- > 4 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 89b14729d59f..e71189454bf0 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -1116,7 +1116,7 @@ static inline void memcg_memory_event_mm(struct mm_struct *mm, > rcu_read_unlock(); > } > > -void split_page_memcg(struct page *head, unsigned int nr); > +void split_page_memcg(struct page *head, unsigned int nr, unsigned int new_order); It looks a bit inconsistent, can't we switch to use either nr or order for both arguments? The latter is preferable. Other than that, the patch looks good to me. Thanks!