From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCAEBC433EF for ; Fri, 18 Mar 2022 17:32:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B7638D0003; Fri, 18 Mar 2022 13:32:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1671D8D0001; Fri, 18 Mar 2022 13:32:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F21D08D0003; Fri, 18 Mar 2022 13:32:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id E3E328D0001 for ; Fri, 18 Mar 2022 13:32:11 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AE75325518 for ; Fri, 18 Mar 2022 17:32:11 +0000 (UTC) X-FDA: 79258200462.15.2F443B2 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf26.hostedemail.com (Postfix) with ESMTP id 34B3A140032 for ; Fri, 18 Mar 2022 17:32:11 +0000 (UTC) Received: by mail-pl1-f178.google.com with SMTP id t22so7529894plo.0 for ; Fri, 18 Mar 2022 10:32:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EdgICBSx30HyYfo1Vfv7IDSnJiyy8MgsSfGKAttnYVg=; b=egGHMuCYPkCj4tcVAbZQAnfcMI1Ux1Oe+2/+8STcZ0Q1T8ndYieave4kV99rYoPYwq 4x7tlFrdNA5u6w3Wb/BIinfJCYEGZDUi7rrAL3F8qCAoGHNSBCvOzUHvdaoKpCw24w/r XZIwyC+rg6Yu283b4pvPBSXTcty37Rtfe9MmoqxwshhUwe0UHjkO0OZz5zzxGS9nELbc pPaHWMc/URLe9ApGEWkzDLLiwTDNk46lAqcZht/+tGo9iDeesoKJKZhcVq4X5uPC/7c3 YVtkzH3rUYuXiyzW6cOAcB9wwM/g8x9eomRGMrYu57joA04yW8lXskH5S7uGlhO7Ki46 Se6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=EdgICBSx30HyYfo1Vfv7IDSnJiyy8MgsSfGKAttnYVg=; b=bg34heAuiQ7Hm9GqDOnToEwWxWd0GaLnWdwHXAmkzJMKg2ZVIvS3MLfStPfZWcKLSp qz4JLHybkp0XCyRFKdzhUjW/X0uzGMd7i6vsxXKsEtKoBKRzZ6prebZY/96dLRbIqC+y RCDa1MyrvuEe9C8w2k8aVA4yDLJlRvE+81hjjUr13QqTfkdlFp4FO4vxNy4o1j/iuL1c vrB1oVYp7HFfpseckjdSjs6QqWVUjd9YuUE5hJqeaUOww4W+MOYXnhzreRIjLuocGgUc b3Bc7X+7le068ZtQVIT12jyWzIf7jE/tXDIqTcOHEwS2JOiQh7794SJ8eagnvS2TyfAZ l7IQ== X-Gm-Message-State: AOAM5310Wu9C1ySXAyjZDDpX7d4FaQPhNlMbgYh91SIQm9DvO2S1OcnR KxUfn36W+5Aha2HPeePf8oA= X-Google-Smtp-Source: ABdhPJw3/ByU76tKO2bD48AXDGH4NMU3ah0PNGXbFs3dAk3waO8l9IVy8+SV/EqMYpksFwtEUgKSSA== X-Received: by 2002:a17:903:1108:b0:151:9c42:7d1 with SMTP id n8-20020a170903110800b001519c4207d1mr563498plh.54.1647624730241; Fri, 18 Mar 2022 10:32:10 -0700 (PDT) Received: from google.com ([2620:15c:211:201:20b4:90a0:8e2e:6022]) by smtp.gmail.com with ESMTPSA id q8-20020aa78428000000b004f7281cda23sm9855069pfn.201.2022.03.18.10.32.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Mar 2022 10:32:09 -0700 (PDT) Date: Fri, 18 Mar 2022 10:32:07 -0700 From: Minchan Kim To: Ivan Babrou Cc: Linux MM , linux-kernel , Andrew Morton , Nitin Gupta , Sergey Senozhatsky , Jens Axboe , linux-block@vger.kernel.org, kernel-team Subject: Re: zram corruption due to uninitialized do_swap_page fault Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 34B3A140032 X-Stat-Signature: 1k4j3cc7oembew3zxcr6dcr5zbs7ji39 X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=egGHMuCY; spf=pass (imf26.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-HE-Tag: 1647624731-6040 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000585, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 18, 2022 at 09:30:09AM -0700, Ivan Babrou wrote: > On Wed, Mar 16, 2022 at 11:26 AM Ivan Babrou wrote: > > I'm making an internal build and will push it to some location to see > > how it behaves, but it might take a few days to get any sort of > > confidence in the results (unless it breaks immediately). > > > > I've also pushed my patch that disables SWP_SYNCHRONOUS_IO to a few > > locations yesterday to see how it fares. > > I have some updates before the weekend. There are two experimental groups: > > * My patch that removes the SWP_SYNCHRONOUS_IO flag. There are 704 > machines in this group across 5 datacenters with cumulative uptime of > 916 days. > * Minchan's patch to remove swap_slot_free_notify. There are 376 > machines in this group across 3 datacenters with cumulative uptime of > 240 days. > > Our machines take a couple of hours to start swapping anything after > boot, and I discounted these two hours from the cumulative uptime. > > Neither of these two groups experienced unexpected coredumps or > rocksdb corruptions. > > I think at this point it's reasonable to proceed with Minchan's patch > (including a backport). Let me cook the patch and then will post it. Thanks for the testing as well as reporting, Ivan!