From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89224C433F5 for ; Fri, 18 Mar 2022 14:30:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0B028D0002; Fri, 18 Mar 2022 10:30:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C93358D0001; Fri, 18 Mar 2022 10:30:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B33D58D0002; Fri, 18 Mar 2022 10:30:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0104.hostedemail.com [216.40.44.104]) by kanga.kvack.org (Postfix) with ESMTP id 9E7028D0001 for ; Fri, 18 Mar 2022 10:30:56 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1C2918249980 for ; Fri, 18 Mar 2022 14:30:56 +0000 (UTC) X-FDA: 79257743712.29.A6D9708 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf25.hostedemail.com (Postfix) with ESMTP id 76A96A0035 for ; Fri, 18 Mar 2022 14:30:53 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 1E241CE28F8; Fri, 18 Mar 2022 14:30:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A91AFC340E8; Fri, 18 Mar 2022 14:30:47 +0000 (UTC) Date: Fri, 18 Mar 2022 14:30:43 +0000 From: Catalin Marinas To: Kuan-Ying Lee Cc: Andrew Morton , Matthias Brugger , chinwen.chang@mediatek.com, nicholas.tang@mediatek.com, yee.lee@mediatek.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] mm/kmemleak: Reset tag when compare object pointer Message-ID: References: <20220318034051.30687-1-Kuan-Ying.Lee@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220318034051.30687-1-Kuan-Ying.Lee@mediatek.com> X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 76A96A0035 X-Stat-Signature: 9tdgbzr9ycmhpcjhxhrhroqrp1h9o7fs X-HE-Tag: 1647613853-38432 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 18, 2022 at 11:40:48AM +0800, Kuan-Ying Lee wrote: > When we use HW-tag based kasan and enable vmalloc support, we hit > the following bug. It is due to comparison between tagged object > and non-tagged pointer. > > We need to reset the kasan tag when we need to compare tagged object > and non-tagged pointer. > > [ 7.690429][T400001] init: kmemleak: [name:kmemleak&]Scan area larger than object 0xffffffe77076f440 > [ 7.691762][T400001] init: CPU: 4 PID: 1 Comm: init Tainted: G S W 5.15.25-android13-0-g5cacf919c2bc #1 > [ 7.693218][T400001] init: Hardware name: MT6983(ENG) (DT) > [ 7.693983][T400001] init: Call trace: > [ 7.694508][T400001] init: dump_backtrace.cfi_jt+0x0/0x8 > [ 7.695272][T400001] init: dump_stack_lvl+0xac/0x120 > [ 7.695985][T400001] init: add_scan_area+0xc4/0x244 > [ 7.696685][T400001] init: kmemleak_scan_area+0x40/0x9c > [ 7.697428][T400001] init: layout_and_allocate+0x1e8/0x288 > [ 7.698211][T400001] init: load_module+0x2c8/0xf00 > [ 7.698895][T400001] init: __se_sys_finit_module+0x190/0x1d0 > [ 7.699701][T400001] init: __arm64_sys_finit_module+0x20/0x30 > [ 7.700517][T400001] init: invoke_syscall+0x60/0x170 > [ 7.701225][T400001] init: el0_svc_common+0xc8/0x114 > [ 7.701933][T400001] init: do_el0_svc+0x28/0xa0 > [ 7.702580][T400001] init: el0_svc+0x60/0xf8 > [ 7.703196][T400001] init: el0t_64_sync_handler+0x88/0xec > [ 7.703964][T400001] init: el0t_64_sync+0x1b4/0x1b8 > [ 7.704658][T400001] init: kmemleak: [name:kmemleak&]Object 0xf5ffffe77076b000 (size 32768): > [ 7.705824][T400001] init: kmemleak: [name:kmemleak&] comm "init", pid 1, jiffies 4294894197 > [ 7.707002][T400001] init: kmemleak: [name:kmemleak&] min_count = 0 > [ 7.707886][T400001] init: kmemleak: [name:kmemleak&] count = 0 > [ 7.708718][T400001] init: kmemleak: [name:kmemleak&] flags = 0x1 > [ 7.709574][T400001] init: kmemleak: [name:kmemleak&] checksum = 0 > [ 7.710440][T400001] init: kmemleak: [name:kmemleak&] backtrace: > [ 7.711284][T400001] init: module_alloc+0x9c/0x120 > [ 7.712015][T400001] init: move_module+0x34/0x19c > [ 7.712735][T400001] init: layout_and_allocate+0x1c4/0x288 > [ 7.713561][T400001] init: load_module+0x2c8/0xf00 > [ 7.714291][T400001] init: __se_sys_finit_module+0x190/0x1d0 > [ 7.715142][T400001] init: __arm64_sys_finit_module+0x20/0x30 > [ 7.716004][T400001] init: invoke_syscall+0x60/0x170 > [ 7.716758][T400001] init: el0_svc_common+0xc8/0x114 > [ 7.717512][T400001] init: do_el0_svc+0x28/0xa0 > [ 7.718207][T400001] init: el0_svc+0x60/0xf8 > [ 7.718869][T400001] init: el0t_64_sync_handler+0x88/0xec > [ 7.719683][T400001] init: el0t_64_sync+0x1b4/0x1b8 > > Signed-off-by: Kuan-Ying Lee Reviewed-by: Catalin Marinas