From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0333CC433EF for ; Wed, 16 Mar 2022 14:11:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E0B86B0072; Wed, 16 Mar 2022 10:11:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 868248D0002; Wed, 16 Mar 2022 10:11:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E2C88D0001; Wed, 16 Mar 2022 10:11:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0254.hostedemail.com [216.40.44.254]) by kanga.kvack.org (Postfix) with ESMTP id 5BFB26B0072 for ; Wed, 16 Mar 2022 10:11:48 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1A7C48249980 for ; Wed, 16 Mar 2022 14:11:48 +0000 (UTC) X-FDA: 79250437896.16.0ED76F6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 5EA571C0023 for ; Wed, 16 Mar 2022 14:11:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tJ8jKnnq2oXOf2skIlAI6sEObeCdDa1t+RvJj1Qq/nw=; b=kuzTZXSYLrAgnvQEbI3bH3jaMA 4wqExcDMLUCVCJJ5tcjy3/aQqnOwSveFurPpT9bJo7r21iISrci7K+Xehr4MVhwBo0ginPmQCGhGw LwCrwV28DYES1833szbLoSP76NO53WBamM4MZMP8QG+gJLHqm2iZDLyJ8/EsQbwK68l2/8hxhhtVj +7kBLHTkRrJfi5Ig7OHqNfG7zEvGkFKDegjebQKguyAveOXgHXv/RlsBu1Jn4sAcB41J2WqXQSu+s jxk1Ictqbgyswq9g9iKeQgd/YRoO9jwfYTlx9BykcRdZAwvsxjbxJ/FsP3xdALL8KxVFvgSDgsAwB sN7nSXJg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUUND-0062Mi-Rj; Wed, 16 Mar 2022 14:11:35 +0000 Date: Wed, 16 Mar 2022 14:11:35 +0000 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, sj@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon: minor cleanup for damon_pa_young Message-ID: References: <20220316081528.6034-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220316081528.6034-1-linmiaohe@huawei.com> X-Stat-Signature: 9ixc1j3khismdpjp494etrtyw19kdxp3 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kuzTZXSY; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5EA571C0023 X-HE-Tag: 1647439906-237490 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 16, 2022 at 04:15:28PM +0800, Miaohe Lin wrote: > if need_lock is true but folio_trylock fails, we should return false > instead of NULL to match the return value type exactly. No functional > change intended. Thanks. Given the extensive changes I've made to this function for this merge window, I've added it to my for-next tree.