From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C265C433F5 for ; Tue, 15 Mar 2022 12:40:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFBCF8D0002; Tue, 15 Mar 2022 08:40:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CAA5D8D0001; Tue, 15 Mar 2022 08:40:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B99928D0002; Tue, 15 Mar 2022 08:40:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0243.hostedemail.com [216.40.44.243]) by kanga.kvack.org (Postfix) with ESMTP id A7AB48D0001 for ; Tue, 15 Mar 2022 08:40:01 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5351A9BE3F for ; Tue, 15 Mar 2022 12:40:01 +0000 (UTC) X-FDA: 79246577802.27.168B2C1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id 55CAC140016 for ; Tue, 15 Mar 2022 12:40:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mbmH2/7iNqchy9xJr/7G1YcqvwOThvxqhQn1/DEFSlE=; b=fb4nEVRI3OY3KyUSB+B/+w82GB SnIMMtWyQEDc8aEqtn3K20stkh+AR9IlNMrcDm5xKDCF6qPBWhngNBsxnM6aK1XmoEBU829rUOkSC 1ab2QGIqX/aFK0ohpnf88gGX8rczRBTQomn+H7nv62FDjiMCMXjPYI8iMgDQvDJO/vkZ6pCu2XGPj h3Lfod+h+kI4egwwUeUf1VHYZSHk+vZYI4P0/Ezd7hi1/jCA58noAdDoKDeGxCyWy1gyeOwIuLoxH n79RfdFb4Y2n4Pf40pKfsWvv4x1lnanmJ+aBaKRaPcNeBElls/LqLvk6V22AucYOrkhhgHUxVCYsf 8MLO4/PQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nU6Sx-00529D-Bj; Tue, 15 Mar 2022 12:39:55 +0000 Date: Tue, 15 Mar 2022 12:39:55 +0000 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, hughd@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mlock: Use vma_lookup() instead of find_vma() Message-ID: References: <20220314151728.20800-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=fb4nEVRI; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 55CAC140016 X-Stat-Signature: raf8rpsp94kkykqo6npngndwtxa8nw9t X-HE-Tag: 1647348000-259823 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 15, 2022 at 08:24:04PM +0800, Miaohe Lin wrote: > On 2022/3/15 0:16, Matthew Wilcox wrote: > > On Mon, Mar 14, 2022 at 11:17:28PM +0800, Miaohe Lin wrote: > >> Using vma_lookup() verifies the start is contained in the found vma. This > >> results in easier to read the code. > > > > This conflicts with the maple tree. > > IIUC, maple tree is the implementation detail of the vma and this patch > should not be conflict with it. But there might be some trival conflict. > Am I supposed to delay this patch until the maple tree's work is done? This function is rewritten as part of the maple tree patchset. There's no point in merging it now, or later.