From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07384C433F5 for ; Tue, 15 Mar 2022 08:32:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 780D08D0002; Tue, 15 Mar 2022 04:32:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 709448D0001; Tue, 15 Mar 2022 04:32:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 583128D0002; Tue, 15 Mar 2022 04:32:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 44DDE8D0001 for ; Tue, 15 Mar 2022 04:32:47 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 15A9D20EEC for ; Tue, 15 Mar 2022 08:32:47 +0000 (UTC) X-FDA: 79245954774.15.40EB8EF Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf02.hostedemail.com (Postfix) with ESMTP id 765328000E for ; Tue, 15 Mar 2022 08:32:46 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 07B491F37E; Tue, 15 Mar 2022 08:32:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1647333165; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bYkhOc7jYnnaJzo+1Uv/M+ohxdNO0S/jT3vuFCDsVq0=; b=tYVVwupkSeyTkjuwC7GpGjykJWyIg0x1HfB8jJm6mimuRYUph0g8UTUQCdlRC2N4ZB5eKX ypjBzvT8agH+7xZwFvfK3G5hxO46HseVzv0cTeiPRHMIIIcVSrm3Wk2J2AK4y88kmSqw3v tT+lmUV0xKRyt8xM0LbFz3Hc2GZyaqE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1647333165; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bYkhOc7jYnnaJzo+1Uv/M+ohxdNO0S/jT3vuFCDsVq0=; b=JKMGLIfKHl/kcVKS1aposzv2vEEp3oEOhbC4yLi9tZVRs7XOP46OlBqJBP5GPGAam4h9Td HfFFjPpRdg//y6Ag== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8E84813B4E; Tue, 15 Mar 2022 08:32:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wWoEICxPMGLdZgAAMHmgww (envelope-from ); Tue, 15 Mar 2022 08:32:44 +0000 Date: Tue, 15 Mar 2022 09:32:42 +0100 From: Oscar Salvador To: "Huang, Ying" Cc: Andrew Morton , Dave Hansen , Abhishek Goel , Baolin Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mm: Only re-generate demotion targets when a numa node changes its N_CPU state Message-ID: References: <20220314150945.12694-1-osalvador@suse.de> <87pmmn3eh6.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87pmmn3eh6.fsf@yhuang6-desk2.ccr.corp.intel.com> X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=tYVVwupk; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=JKMGLIfK; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf02.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 765328000E X-Stat-Signature: 794cd8cmwmrudtpu5ncyim4o6wd31sqo X-HE-Tag: 1647333166-284242 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 15, 2022 at 02:40:53PM +0800, Huang, Ying wrote: > Oscar Salvador writes: > CPUHP_MM_DEMOTION_DEAD and CPUHP_AP_MM_DEMOTION_ONLINE needs to be > deleted from include/linux/cpuhotplug.h too. Hi Huang Ying, Right. Andrew, can you apply this on top? Thanks diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h index 411a428ace4d..8a9a2d01b7c6 100644 --- a/include/linux/cpuhotplug.h +++ b/include/linux/cpuhotplug.h @@ -72,8 +72,6 @@ enum cpuhp_state { CPUHP_SLUB_DEAD, CPUHP_DEBUG_OBJ_DEAD, CPUHP_MM_WRITEBACK_DEAD, - /* Must be after CPUHP_MM_VMSTAT_DEAD */ - CPUHP_MM_DEMOTION_DEAD, CPUHP_MM_VMSTAT_DEAD, CPUHP_SOFTIRQ_DEAD, CPUHP_NET_MVNETA_DEAD, @@ -244,8 +242,6 @@ enum cpuhp_state { CPUHP_AP_BASE_CACHEINFO_ONLINE, CPUHP_AP_ONLINE_DYN, CPUHP_AP_ONLINE_DYN_END = CPUHP_AP_ONLINE_DYN + 30, - /* Must be after CPUHP_AP_ONLINE_DYN for node_states[N_CPU] update */ - CPUHP_AP_MM_DEMOTION_ONLINE, CPUHP_AP_X86_HPET_ONLINE, CPUHP_AP_X86_KVM_CLK_ONLINE, CPUHP_AP_ACTIVE, Huang Ying, it would be great to have your Reviewed-by/Acked-by if you are ok with the outome. Thanks -- Oscar Salvador SUSE Labs