From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5708FC433F5 for ; Fri, 25 Mar 2022 07:46:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D4A76B0073; Fri, 25 Mar 2022 03:46:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 883528D0002; Fri, 25 Mar 2022 03:46:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74B7E8D0001; Fri, 25 Mar 2022 03:46:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id 67CF36B0073 for ; Fri, 25 Mar 2022 03:46:45 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 33C5EA30AB for ; Fri, 25 Mar 2022 07:46:45 +0000 (UTC) X-FDA: 79282126770.30.A6736B8 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf05.hostedemail.com (Postfix) with ESMTP id A08D2100028 for ; Fri, 25 Mar 2022 07:46:44 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 1B9BA1F745; Fri, 25 Mar 2022 07:46:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1648194403; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LGMOuXB7AbKqx+2GTktrlM5bbqBSU6RPeiMitMpafNQ=; b=Mo16838jUIyFoR4/+g9qGoohV0hADpi19padXFDxSLQ6o6b3VGgGrjK7DOZ7aClDHqtkk8 3Vei3tohr98FCIN2aEN8Z7Ys2ZTqpu/jj4R6hvTxoOms0hM2d9rrDcXkBwjrDpC/AUdi7C 9us7MWsQw++dXlURxCRigjRLKqSrubI= Received: from suse.cz (mhocko.udp.ovpn2.prg.suse.de [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id E31ACA3B82; Fri, 25 Mar 2022 07:46:42 +0000 (UTC) Date: Fri, 25 Mar 2022 08:46:42 +0100 From: Michal Hocko To: Tiezhu Yang Cc: "Chen, Rong A" , kernel test robot , kbuild-all@lists.01.org, Thomas Bogendoerfer , linux-kernel@vger.kernel.org, Oscar Salvador , Andrew Morton , Linux Memory Management List , linux-mips@vger.kernel.org, chenfeiyang@loongson.cn Subject: Re: [kbuild-all] Re: undefined reference to `node_data' Message-ID: References: <202203232042.AS9SV1zv-lkp@intel.com> <20220324090443.GA5375@alpha.franken.de> <06178ca0-66ad-c7fc-a79c-0ea1873408bd@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: nhagy9swz6bcrswbfzo9iuiyg1izqkwm Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Mo16838j; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf05.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: A08D2100028 X-HE-Tag: 1648194404-433475 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 25-03-22 11:40:37, Tiezhu Yang wrote: > > > On 03/25/2022 09:16 AM, Chen, Rong A wrote: > > > > > > On 3/24/2022 8:40 PM, Michal Hocko wrote: > > > On Thu 24-03-22 10:04:43, Thomas Bogendoerfer wrote: > > > > On Wed, Mar 23, 2022 at 05:46:59PM +0100, Michal Hocko wrote: > > > > > > > If you fix the issue, kindly add following tag as appropriate > > > > > > > Reported-by: kernel test robot > > > > > > > > > > > > > > All errors (new ones prefixed by >>): > > > > > > > > > > > > > > mips64-linux-ld: mm/page_alloc.o: in function `free_area_init': > > > > > > > > > (.init.text+0x1680): undefined reference to `node_data' > > > > > > > mips64-linux-ld: (.init.text+0x1690): undefined reference to > > > > > > > `node_data' > > > > > > > > > > > > OK, I can see what is going here. The page allocator normally > > > > > > uses NODE_DATA but arch_refresh_nodedata refers to node_data directly. > > > > > > This is a problem with > > > > > > arch/mips/include/asm/mach-loongson64/mmzone.h: > > > > > > extern struct pglist_data *__node_data[]; > > > > > > > > > > > > #define NODE_DATA(n) (__node_data[n]) > > > > > > > > > > > > Unfortunately we cannot use NODE_DATA there because of header > > > > > > inclusion > > > > > > ordering. I will think about a solution. > > > > > > > > > > Is there any reason why (some?) MIPS arches use __node_data rather than > > > > > node_data as most other architectures? Would it be acceptable to do the > > > > > renaming? It would help to cover the above compilation problem because > > > > > arch_refresh_nodedata could keep using node_data directly. > > > > > > > > I've just checked history and I don't see a reason for __node_data. > > > > So I'm fine with changing it to node_data. > > > > > > Thanks a lot for double checking Thomas! This is a dump&simple sed over > > > mips file. 0-day guys, could you give it a try please? > > > > > > Hi Michal, > > > > It returns another error: > > Hi, > > I think the following patch should fix the build error > "undefined reference to `node_data'": > > https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/commit/?id=f8f9f21c7848 Thanks that looks much better than my renaming patch. Thanks a lot. FWIW Acked-by: Michal Hocko -- Michal Hocko SUSE Labs