From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 915C7C433EF for ; Thu, 10 Mar 2022 12:09:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BF6F8D0002; Thu, 10 Mar 2022 07:09:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 16E4F8D0001; Thu, 10 Mar 2022 07:09:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05D7C8D0002; Thu, 10 Mar 2022 07:09:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0126.hostedemail.com [216.40.44.126]) by kanga.kvack.org (Postfix) with ESMTP id EE1678D0001 for ; Thu, 10 Mar 2022 07:09:24 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A46EA1817902F for ; Thu, 10 Mar 2022 12:09:24 +0000 (UTC) X-FDA: 79228356648.18.12EAE89 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 2161B4001D for ; Thu, 10 Mar 2022 12:09:24 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5A04561761; Thu, 10 Mar 2022 12:09:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F13EBC340E8; Thu, 10 Mar 2022 12:09:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646914162; bh=LhRmS+vrpZoaKwfJVC57Idu15/prJ7woDjjR7jrcjPY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=stFUZYEVIhJ33uhot09+27wns6i0gdE+IViaKwq8Q6Vjx4Tvw70OFrz3espB1Y1O+ YsESKWQT0+BgyELvqUslKITgmtf+s865Z53CKBCURtIjie4HZchmVSwWLz28wu2jfJ ln0xUqZcK7hSG6tffko2ALLRsqT//dnhiUrRPSGOujii4cF0U4z6bWdCJDxwCFPdnI YTSAOj+B0Dk79CZTM9qc3lpexXit+tSjGUs2g85lN9c70J7SoG/4IJhQ4kd3Y2RX2j hvoKT7Q43mlJCaOLPkc2VQDqXOs7/luSlVG3bq9090vESJCrd4IrQShI9YreFDFByu UV/fNGYOK3fAA== Date: Thu, 10 Mar 2022 14:09:12 +0200 From: Mike Rapoport To: Joao Martins Cc: linux-mm@kvack.org, Dan Williams , Vishal Verma , Matthew Wilcox , Jason Gunthorpe , Jane Chu , Muchun Song , Mike Kravetz , Andrew Morton , Jonathan Corbet , Christoph Hellwig , nvdimm@lists.linux.dev, linux-doc@vger.kernel.org Subject: Re: [PATCH v8 3/5] mm/hugetlb_vmemmap: move comment block to Documentation/vm Message-ID: References: <20220307122457.10066-1-joao.m.martins@oracle.com> <20220307122457.10066-4-joao.m.martins@oracle.com> <1debf72b-8354-604e-1574-bf956c869dd7@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1debf72b-8354-604e-1574-bf956c869dd7@oracle.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2161B4001D X-Stat-Signature: atnux3zsfce79ho6rfwz5zyqhr4oaupj Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=stFUZYEV; spf=pass (imf01.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1646914164-746630 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 10, 2022 at 11:32:21AM +0000, Joao Martins wrote: > On 3/10/22 10:32, Mike Rapoport wrote: > > Hi, > > > > On Mon, Mar 07, 2022 at 12:24:55PM +0000, Joao Martins wrote: > >> In preparation for device-dax for using hugetlbfs compound page tail > >> deduplication technique, move the comment block explanation into a > >> common place in Documentation/vm. > >> > >> Cc: Muchun Song > >> Cc: Mike Kravetz > >> Suggested-by: Dan Williams > >> Signed-off-by: Joao Martins > >> Reviewed-by: Muchun Song > >> Reviewed-by: Dan Williams > >> --- > >> Documentation/vm/index.rst | 1 + > >> Documentation/vm/vmemmap_dedup.rst | 173 +++++++++++++++++++++++++++++ > > > > Sorry for jumping late. > > > > Please consider moving this into Documentation/vm/memory-model.rst along > > with the documentation added in the next patch > > > Hmmm, I don't think this is the right place to put it. > > We don't change the memory model fundamentally (rather the *backing* pages of > vmemmap VA in some specific cases) to justify putting the entire thing there. > The new doc is also just as big as memory-model.rst doc. I feel the two separate > docs stand on their own and the vmemmap dedup technique doc is better placed as > its own. > > Perhaps alternatively (in a followup patch) it could get a relevant mention > (either in an new subsection or in paragraphs of the existing subsections) > in memory-model.rst to point readers to vmemmap_dedup.rst...? Sounds good to me. -- Sincerely yours, Mike.