From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 076AFC433EF for ; Wed, 9 Mar 2022 21:55:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 776788D0002; Wed, 9 Mar 2022 16:55:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 725878D0001; Wed, 9 Mar 2022 16:55:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EE128D0002; Wed, 9 Mar 2022 16:55:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 508C28D0001 for ; Wed, 9 Mar 2022 16:55:33 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1B10321023 for ; Wed, 9 Mar 2022 21:55:33 +0000 (UTC) X-FDA: 79226204946.04.CFD9C28 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf18.hostedemail.com (Postfix) with ESMTP id 8975B1C0003 for ; Wed, 9 Mar 2022 21:55:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 28C361F381; Wed, 9 Mar 2022 21:55:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1646862931; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E0v4Okq/Vwj1DkpbTQ/9vduUBRNNE2OxrDnwQN8oagM=; b=kgCMDQHjfIweWJ7IUKQ5lam5cwnoZap9GTsGimg8VSK2YPD0BvdEIJH6QJdnWgioPhM/iD eF0oKqZUjCuUom072AYgJ6EWiracAgdKaQfecIlJk6KOwGlQZnpWJNxZdQ6XiukLWR5pjE sZKa8K4fWRBV08qdsHvwkX2JmfeQcMA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1646862931; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E0v4Okq/Vwj1DkpbTQ/9vduUBRNNE2OxrDnwQN8oagM=; b=HCURMcqzfjDCSbhpPyiVULe4R9gh3HN3BvV8xFmDkWlWF0hQToZV7w1lZ0VbJgEexWr8BL h7Xob+aZzdDEbtCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B37C513D7F; Wed, 9 Mar 2022 21:55:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id pjYlKFIiKWIzdgAAMHmgww (envelope-from ); Wed, 09 Mar 2022 21:55:30 +0000 Date: Wed, 9 Mar 2022 22:55:29 +0100 From: Oscar Salvador To: Andrew Morton Cc: Dave Hansen , "Huang, Ying" , Abhishek Goel , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Only re-generate demotion targets when a numa node changes its N_CPU state Message-ID: References: <20220309144644.4278-1-osalvador@suse.de> <20220309130249.60733272aafb3bd5f2e6b88c@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220309130249.60733272aafb3bd5f2e6b88c@linux-foundation.org> X-Rspamd-Queue-Id: 8975B1C0003 X-Stat-Signature: rbs8dkbqrd6ady3m793tkqrrnmbxdf3o Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=kgCMDQHj; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=HCURMcqz; spf=pass (imf18.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1646862932-606198 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 09, 2022 at 01:02:49PM -0800, Andrew Morton wrote: > On Wed, 9 Mar 2022 15:46:44 +0100 Oscar Salvador wrote: > > +static inline void set_migration_target_nodes() {} > > Compiler won't like that. Please test (compile and runtime) with > CONFIG_HOTPLUG_CPU=n. Sorry, fat fingers. This on top: diff --git a/include/linux/migrate.h b/include/linux/migrate.h index c64fe2923fb0..b82b4a9a0136 100644 --- a/include/linux/migrate.h +++ b/include/linux/migrate.h @@ -51,7 +51,7 @@ extern bool numa_demotion_enabled; #ifdef CONFIG_HOTPLUG_CPU extern void set_migration_target_nodes(void); #else -static inline void set_migration_target_nodes() {} +static inline void set_migration_target_nodes(void) {} #endif #else I will wait for some feedback before sending a v2. thanks Andrew! -- Oscar Salvador SUSE Labs