From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 608D2C433EF for ; Wed, 9 Mar 2022 15:29:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C06878D0002; Wed, 9 Mar 2022 10:29:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BB54F8D0001; Wed, 9 Mar 2022 10:29:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA3A98D0002; Wed, 9 Mar 2022 10:29:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 9BC3B8D0001 for ; Wed, 9 Mar 2022 10:29:12 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 672D622316 for ; Wed, 9 Mar 2022 15:29:12 +0000 (UTC) X-FDA: 79225231344.10.99D2145 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 17B7BC000B for ; Wed, 9 Mar 2022 15:29:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5RgX5tZLSsAtO9xXtxg7N8PS6/VOcsvGlxTOVBEJBiM=; b=IIm9rfkLwI0uUdNY/9J8RWA0Mj MHDmjb4uDI+o59odgPocvlaFEGFxkzkdE0jg6Whr093gioLjaDo8EhFWiXjp9m29xSmxWV9gjHRBZ Ltj3327XbxYtmXa+lpV9PsOd8Bc4BSpZuGdyNYGOBEBGet6DvgQ3hwiaFgusrkBS4lNregjBX6B+p JWyMVASql6a7M6QxATsuSChFlxygafIlSkhO2Aqg8eJo4FS4kiujDeFkjq9CL1qJNW5Gm0BWEINrd ddQVsh5E2GdGyqTG59E3pNkuTg854nMNSpiWcJ3fFz/mItx4PishD+b+D1QYj8OJJ9OD0yKo6x+Ts VNhjlusA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRyF5-00HEaa-UG; Wed, 09 Mar 2022 15:28:48 +0000 Date: Wed, 9 Mar 2022 15:28:47 +0000 From: Matthew Wilcox To: sxwjean@me.com Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, longman@redhat.com, guro@fb.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiongwei Song Subject: Re: [PATCH 2/2] mm: slub: Delete useless parameter of alloc_slab_page() Message-ID: References: <20220309145052.219138-1-sxwjean@me.com> <20220309145052.219138-3-sxwjean@me.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220309145052.219138-3-sxwjean@me.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 17B7BC000B X-Stat-Signature: fodbef4g4m6a149rcna1ppzm567ffce3 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=IIm9rfkL; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1646839750-558193 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 09, 2022 at 10:50:52PM +0800, sxwjean@me.com wrote: > From: Xiongwei Song > > The parameter @s is useless for alloc_slab_page(), let's delete it. Perhaps we could add a little more information here. It was added in 2014 by 5dfb41750992 ("sl[au]b: charge slabs to kmemcg explicitly"). The need for it was removed in 2020 by 1f3147b49d75 ("mm: slub: call account_slab_page() after slab page initialization"). Reviewed-by: Matthew Wilcox (Oracle)