From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94F09C433FE for ; Wed, 9 Mar 2022 13:48:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88A7A8D0002; Wed, 9 Mar 2022 08:48:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 839898D0001; Wed, 9 Mar 2022 08:48:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 701108D0002; Wed, 9 Mar 2022 08:48:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0047.hostedemail.com [216.40.44.47]) by kanga.kvack.org (Postfix) with ESMTP id 5CE138D0001 for ; Wed, 9 Mar 2022 08:48:49 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 124EBA0FB8 for ; Wed, 9 Mar 2022 13:48:49 +0000 (UTC) X-FDA: 79224978378.23.0EA05A4 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf13.hostedemail.com (Postfix) with ESMTP id EB69820008 for ; Wed, 9 Mar 2022 13:48:47 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 7667E1F381; Wed, 9 Mar 2022 13:48:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1646833726; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NmqS7ZxhbO47ovim+J2EyZsGVX8eOAA0CiaG2u3dAcc=; b=BSZiI8/V+gSeLNp9LUeQx5MnXFEY6ewbJlggU5HYnG40WdE7XcXePudKhmbmRTbtygeJC9 iOBVRhuFi5Q4rgyxUSkYX8rD8+bYWIZ9UC3MahrzjLke+daGGuNFP5y9OnIUEbvN83izCC i+LQ38tRFvPwAYrdkfijL5a9j/s3VPU= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id D7ACAA3B91; Wed, 9 Mar 2022 13:48:40 +0000 (UTC) Date: Wed, 9 Mar 2022 14:48:45 +0100 From: Michal Hocko To: Wei Yang Cc: hannes@cmpxchg.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Tim Chen Subject: Re: [PATCH 3/3] mm/memcg: add next_mz back if not reclaimed yet Message-ID: References: <20220308012047.26638-1-richard.weiyang@gmail.com> <20220308012047.26638-3-richard.weiyang@gmail.com> <20220309004620.fgotfh4wsquscbfn@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220309004620.fgotfh4wsquscbfn@master> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EB69820008 X-Stat-Signature: 878imjwfx6rfdmt5pb89x5em9fue3tzo Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="BSZiI8/V"; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspam-User: X-HE-Tag: 1646833727-9646 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: [Cc Tim - the patch is http://lkml.kernel.org/r/20220308012047.26638-3-richard.weiyang@gmail.com] On Wed 09-03-22 00:46:20, Wei Yang wrote: > On Tue, Mar 08, 2022 at 09:17:58AM +0100, Michal Hocko wrote: > >On Tue 08-03-22 01:20:47, Wei Yang wrote: > >> next_mz is removed from rb_tree, let's add it back if no reclaim has > >> been tried. > > > >Could you elaborate more why we need/want this? > > > > Per my understanding, we add back the right most node even reclaim makes no > progress, so it is reasonable to add back a node if we didn't get a chance to > do reclaim on it. Your patch sounded familiar and I can remember now. The same fix has been posted by Tim last year https://lore.kernel.org/linux-mm/8d35206601ccf0e1fe021d24405b2a0c2f4e052f.1613584277.git.tim.c.chen@linux.intel.com/ It was posted with other changes to the soft limit code which I didn't like but I have acked this particular one. Not sure what has happened with it afterwards. -- Michal Hocko SUSE Labs