From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87885C433EF for ; Tue, 8 Mar 2022 21:25:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D43E8D0002; Tue, 8 Mar 2022 16:25:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 15DAE8D0001; Tue, 8 Mar 2022 16:25:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3FDF8D0002; Tue, 8 Mar 2022 16:25:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id E1ACD8D0001 for ; Tue, 8 Mar 2022 16:25:02 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D39F824921 for ; Tue, 8 Mar 2022 21:25:00 +0000 (UTC) X-FDA: 79222499160.02.DC6FCED Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf30.hostedemail.com (Postfix) with ESMTP id 62D3F80004 for ; Tue, 8 Mar 2022 21:25:00 +0000 (UTC) Received: by mail-wm1-f44.google.com with SMTP id i66so230835wma.5 for ; Tue, 08 Mar 2022 13:25:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nDOGbN5ER5kyhrbrSeZfaKAJZ4dw3JtTr6jnBgdLbBI=; b=kmHrGTMSvm6tF864EuT2q9gVNsYXS3s2uIcUZWHBIrB9Q8oVsXygqnpmpDyJow/rtB lldvQxzcy5qU3NO7j9RwlGt7C5cuRxfx5L5x+qoB7R/6PFU+YEtXgbcO06pt+DNxgbRg 0kIjeFi+TQVc5+qYRitxrs1b2/ekbArAvz+zBucgyNYqI5PyyYZNMzlMSS3P4pF7aTxl 2zxa7YL1+Vy//v5c8ZaLvqYnfikwRN5rmd6yAm/wttKeNs2HOR4SKL2jEBPLrpWgeBb2 q2DN0hNxiKsbH8Uw0q7n9hZBcaeHq0Ptst/XDlYJYnZd9lcmkWIeR6bLTTqFO2/h3AW9 mGgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nDOGbN5ER5kyhrbrSeZfaKAJZ4dw3JtTr6jnBgdLbBI=; b=Og0kbDVj18Vp0cWKuryUR4iKxUDoO+3i6zmafFRU+BHvfza4/z4ZCixOrxQiG4avD0 6o8yTaVD6BGnEY3uhGwL+ReIyrikrLCp/hnJi0wG5l/9aewNjYWLJAUYCcVhxrk01Ppu AYxscQd6YeGFl9uAsDe1Y3FZYI8DLN0FHftaDHDv0aSk7PN8dJ/3AZDWBaaUfT2EpXhY Cd8OM+bXxPRTU4KYHB66egz4mQiqXHOqKN+388ccYQSYNQxQzQ4KWa4zCbdjCm5L+DVp NSEXEVqx1JYUrMXh7CHU4HZd1lSvetrMlzAckvN21dozCnvMyONd7K4g2TaMbcGs4epV gprA== X-Gm-Message-State: AOAM530iBZfnZECah0LgMWzOCgauktMAtb7LpnDmeJxS+Z80sDLc1KJG XnsaqXJjvutdmpJw6SHTDQ== X-Google-Smtp-Source: ABdhPJxuYGxepEE8cVVoar6pJEOKukfeg0awhEsWbFqsOc0BU99sBdi+fMLBfybk2ElJ5BBGowTeEQ== X-Received: by 2002:a05:600c:3b1c:b0:389:8677:6c73 with SMTP id m28-20020a05600c3b1c00b0038986776c73mr934939wms.192.1646774698977; Tue, 08 Mar 2022 13:24:58 -0800 (PST) Received: from localhost.localdomain ([46.53.254.141]) by smtp.gmail.com with ESMTPSA id b3-20020a5d4d83000000b001f1d72a6f97sm26070wru.50.2022.03.08.13.24.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 13:24:58 -0800 (PST) Date: Wed, 9 Mar 2022 00:24:56 +0300 From: Alexey Dobriyan To: Kees Cook Cc: David Gow , Eric Biederman , Daniel Latypov , Magnus =?utf-8?B?R3Jvw58=?= , Alexander Viro , linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2] binfmt_elf: Introduce KUnit test Message-ID: References: <20220304044831.962450-1-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220304044831.962450-1-keescook@chromium.org> X-Rspamd-Queue-Id: 62D3F80004 X-Stat-Signature: n1opgggbk5u3fo1f1t3f8h7gxko5pmwo Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=kmHrGTMS; spf=pass (imf30.hostedemail.com: domain of adobriyan@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=adobriyan@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1646774700-331140 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 03, 2022 at 08:48:31PM -0800, Kees Cook wrote: > Adds simple KUnit test for some binfmt_elf internals: specifically a > regression test for the problem fixed by commit 8904d9cd90ee ("ELF: > fix overflow in total mapping size calculation"). > + /* No headers, no size. */ > + KUNIT_EXPECT_EQ(test, total_mapping_size(NULL, 0), 0); This is meaningless test. This whole function only makes sense if program headers are read and loading process advances far enough so that pointer is not NULL. Are we going to mock every single function in the kernel? Disgusting.