From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E0D0C433EF for ; Tue, 8 Mar 2022 18:57:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 172F38D0007; Tue, 8 Mar 2022 13:57:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 122D98D0001; Tue, 8 Mar 2022 13:57:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 038418D0007; Tue, 8 Mar 2022 13:57:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id E927B8D0001 for ; Tue, 8 Mar 2022 13:57:03 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B5393208BB for ; Tue, 8 Mar 2022 18:57:03 +0000 (UTC) X-FDA: 79222126326.12.2D96AB5 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf07.hostedemail.com (Postfix) with ESMTP id F003F4000D for ; Tue, 8 Mar 2022 18:57:02 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8C626210ED; Tue, 8 Mar 2022 18:57:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1646765821; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0IfmFdPIHuTa75Qa/8oUKNFdCQJv+DchlDBS9H5YG4g=; b=pBCnBqihs3rV/BlNOD7j+ZB76sI0/mQiVbUmo4Y1slWqqutSwmU941y0E92p9zs+axP5MA 1N+zo8cVSDUtuT93RJnEu+h5Hmd0aAGCGkKl6TrGsQOB6p/W2jTzLxUYBv25M8pARnacJd U5L/w/1zP7/0J8LuxVlGQrIxaxK01qo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1646765821; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0IfmFdPIHuTa75Qa/8oUKNFdCQJv+DchlDBS9H5YG4g=; b=MmAU06sDhhgGSHT7iox+uiNH8sbWBaWDyuuLKEmA5kKxjoS95T5mEkPL9CF5+KuDjuqh5g wV4kmO6vJWq0qEBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C7F7313CE9; Tue, 8 Mar 2022 18:57:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yIJwLfymJ2IBRAAAMHmgww (envelope-from ); Tue, 08 Mar 2022 18:57:00 +0000 Date: Tue, 8 Mar 2022 19:56:59 +0100 From: Oscar Salvador To: Dave Hansen Cc: "Huang, Ying" , Abhishek Goel , Dave Hansen , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zi Yan , David Hildenbrand , Yang Shi , Andrew Morton Subject: Re: [PATCH -V11 2/9] mm/migrate: update node demotion order on hotplug events Message-ID: References: <20210721063926.3024591-1-ying.huang@intel.com> <20210721063926.3024591-2-ying.huang@intel.com> <4e8067e1-0574-c9d2-9d6c-d676d32071bd@linux.vnet.ibm.com> <87pmnb3ccr.fsf@yhuang6-desk2.ccr.corp.intel.com> <86383ac9-e5f2-1a2e-dd19-02e39714a3fd@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86383ac9-e5f2-1a2e-dd19-02e39714a3fd@intel.com> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: F003F4000D X-Stat-Signature: sekoymeuk4n6mqgtgnqo4mqcgkju1d9z Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=pBCnBqih; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=MmAU06sD; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf07.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de X-HE-Tag: 1646765822-351213 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 08, 2022 at 09:07:20AM -0800, Dave Hansen wrote: > On 3/8/22 02:27, Oscar Salvador wrote: > > @@ -2043,7 +2044,12 @@ static void __init init_cpu_node_state(void) > > static int vmstat_cpu_online(unsigned int cpu) > > { > > refresh_zone_stat_thresholds(); > > - node_set_state(cpu_to_node(cpu), N_CPU); > > + > > + if (!node_state(cpu_to_node(cpu), N_CPU)) { > > + node_set_state(cpu_to_node(cpu), N_CPU); > > + set_migration_target_nodes(); > > + } > > + > > return 0; > > } > > > > @@ -2066,6 +2072,8 @@ static int vmstat_cpu_dead(unsigned int cpu) > > return 0; > > > > node_clear_state(node, N_CPU); > > + set_migration_target_nodes(); > > + > > return 0; > > } > > Yeah, those callbacks do look like they're reinventing the wheel. This > is a much more direct way of doing it. Then let me play a bit more with it and I can cook a patch unless someone feels strong against it. Thanks -- Oscar Salvador SUSE Labs