From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84C2AC433F5 for ; Tue, 8 Mar 2022 13:47:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 199838D000F; Tue, 8 Mar 2022 08:47:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 149858D0009; Tue, 8 Mar 2022 08:47:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 011038D000F; Tue, 8 Mar 2022 08:47:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id E4ADB8D0009 for ; Tue, 8 Mar 2022 08:47:45 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B937060840 for ; Tue, 8 Mar 2022 13:47:45 +0000 (UTC) X-FDA: 79221346890.02.473F15F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf23.hostedemail.com (Postfix) with ESMTP id 25E4D140009 for ; Tue, 8 Mar 2022 13:47:45 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id C88001F37E; Tue, 8 Mar 2022 13:47:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1646747263; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M2cDsI5mV1M6x3gdOfjF4IWbEcsh+bq/qA5q8DqCU9o=; b=fTGzL+Af7eT3+Xr2+FC85hjMRC7ZhDBLssNwdwoiK64evmjG9XM7sBl9QI3NDATNY9gLDI Gr1BC0VcIHrXCMfGQkZp0Lq42uC7UwXPlGOy4fKSn4Xp33+fxJlnpie01Q2PCsnw8PCsZY RwF7ozOFU3c9piwYZTC92OpOEbwNtHg= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 4F693A3B84; Tue, 8 Mar 2022 13:47:43 +0000 (UTC) Date: Tue, 8 Mar 2022 14:47:42 +0100 From: Michal Hocko To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Michael Ellerman , Andrew Morton , Dennis Zhou , Tejun Heo , Christoph Lameter , Johannes Weiner , Vladimir Davydov , linux-mm@kvack.org, cgroups@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/3] mm: vmalloc: introduce array allocation functions Message-ID: References: <20220308105918.615575-1-pbonzini@redhat.com> <20220308105918.615575-2-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220308105918.615575-2-pbonzini@redhat.com> X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: tu3dmmpekbgieg1t6cgrbkh11m93ig8b Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=fTGzL+Af; spf=pass (imf23.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspamd-Queue-Id: 25E4D140009 X-HE-Tag: 1646747265-800116 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 08-03-22 05:59:16, Paolo Bonzini wrote: > Linux has dozens of occurrences of vmalloc(array_size()) and > vzalloc(array_size()). Allow to simplify the code by providing > vmalloc_array and vcalloc, as well as the underscored variants that let > the caller specify the GFP flags. > > Cc: stable@vger.kernel.org > Cc: linux-mm@kvack.org > Signed-off-by: Paolo Bonzini Seems useful Acked-by: Michal Hocko Is there any reason you haven't used __alloc_size(1, 2) annotation? Thanks! > --- > include/linux/vmalloc.h | 5 +++++ > mm/util.c | 50 +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 55 insertions(+) > > diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h > index 880227b9f044..d1bbd4fd50c5 100644 > --- a/include/linux/vmalloc.h > +++ b/include/linux/vmalloc.h > @@ -159,6 +159,11 @@ void *__vmalloc_node(unsigned long size, unsigned long align, gfp_t gfp_mask, > int node, const void *caller) __alloc_size(1); > void *vmalloc_no_huge(unsigned long size) __alloc_size(1); > > +extern void *__vmalloc_array(size_t n, size_t size, gfp_t flags) __alloc_size(1, 2); > +extern void *vmalloc_array(size_t n, size_t size) __alloc_size(1, 2); > +extern void *__vcalloc(size_t n, size_t size, gfp_t flags) __alloc_size(1, 2); > +extern void *vcalloc(size_t n, size_t size) __alloc_size(1, 2); > + > extern void vfree(const void *addr); > extern void vfree_atomic(const void *addr); > > diff --git a/mm/util.c b/mm/util.c > index 7e43369064c8..94475abe54a0 100644 > --- a/mm/util.c > +++ b/mm/util.c > @@ -647,6 +647,56 @@ void *kvrealloc(const void *p, size_t oldsize, size_t newsize, gfp_t flags) > } > EXPORT_SYMBOL(kvrealloc); > > +/** > + * __vmalloc_array - allocate memory for a virtually contiguous array. > + * @n: number of elements. > + * @size: element size. > + * @flags: the type of memory to allocate (see kmalloc). > + */ > +void *__vmalloc_array(size_t n, size_t size, gfp_t flags) > +{ > + size_t bytes; > + > + if (unlikely(check_mul_overflow(n, size, &bytes))) > + return NULL; > + return __vmalloc(bytes, flags); > +} > +EXPORT_SYMBOL(__vmalloc_array); > + > +/** > + * vmalloc_array - allocate memory for a virtually contiguous array. > + * @n: number of elements. > + * @size: element size. > + */ > +void *vmalloc_array(size_t n, size_t size) > +{ > + return __vmalloc_array(n, size, GFP_KERNEL); > +} > +EXPORT_SYMBOL(vmalloc_array); > + > +/** > + * __vcalloc - allocate and zero memory for a virtually contiguous array. > + * @n: number of elements. > + * @size: element size. > + * @flags: the type of memory to allocate (see kmalloc). > + */ > +void *__vcalloc(size_t n, size_t size, gfp_t flags) > +{ > + return __vmalloc_array(n, size, flags | __GFP_ZERO); > +} > +EXPORT_SYMBOL(__vcalloc); > + > +/** > + * vcalloc - allocate and zero memory for a virtually contiguous array. > + * @n: number of elements. > + * @size: element size. > + */ > +void *vcalloc(size_t n, size_t size) > +{ > + return __vmalloc_array(n, size, GFP_KERNEL | __GFP_ZERO); > +} > +EXPORT_SYMBOL(vcalloc); > + > /* Neutral page->mapping pointer to address_space or anon_vma or other */ > void *page_rmapping(struct page *page) > { > -- > 2.31.1 -- Michal Hocko SUSE Labs