From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 184BEC433EF for ; Tue, 8 Mar 2022 15:26:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C6788D0003; Tue, 8 Mar 2022 10:26:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6767C8D0001; Tue, 8 Mar 2022 10:26:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 565C88D0003; Tue, 8 Mar 2022 10:26:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0093.hostedemail.com [216.40.44.93]) by kanga.kvack.org (Postfix) with ESMTP id 47F198D0001 for ; Tue, 8 Mar 2022 10:26:31 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id F1CA11828A7E7 for ; Tue, 8 Mar 2022 15:26:30 +0000 (UTC) X-FDA: 79221595782.29.7EFB70E Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf08.hostedemail.com (Postfix) with ESMTP id 5F4CC16000A for ; Tue, 8 Mar 2022 15:26:30 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id F132B1F380; Tue, 8 Mar 2022 15:26:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1646753188; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m2m+Ogcvgk7zAck8lJL9y5rOuyf0bq56RUWhNvKb8gE=; b=OFDOb0EX8vyJa+0LJDX7Xt+dj6BWiRqgtFSXsPFEiYkQ6sdEw/loo4IXxjnn4hrfyZx4nu xtvYdMNA0TmRGdgQCsrBvDWK+/YB3GNo5U1S690uSfCWm1EOUwu+z/F/Fl1e8LfoiK7zg1 decbmKM6dxZOdt3C97MlG/yD3bCKPZY= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 80421A3B83; Tue, 8 Mar 2022 15:26:26 +0000 (UTC) Date: Tue, 8 Mar 2022 16:26:26 +0100 From: Michal Hocko To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Michael Ellerman , Andrew Morton , Dennis Zhou , Tejun Heo , Christoph Lameter , Johannes Weiner , Vladimir Davydov , linux-mm@kvack.org, cgroups@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/3] mm: vmalloc: introduce array allocation functions Message-ID: References: <20220308105918.615575-1-pbonzini@redhat.com> <20220308105918.615575-2-pbonzini@redhat.com> <77a34051-2672-88cf-99dd-60f5acfb905e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <77a34051-2672-88cf-99dd-60f5acfb905e@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5F4CC16000A X-Stat-Signature: nykw7sep4z45k9ts67fznbe69qu17w1k Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=OFDOb0EX; spf=pass (imf08.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-HE-Tag: 1646753190-922251 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 08-03-22 14:55:39, Paolo Bonzini wrote: > On 3/8/22 14:47, Michal Hocko wrote: > > Seems useful > > Acked-by: Michal Hocko > > > > Is there any reason you haven't used __alloc_size(1, 2) annotation? > > It's enough to have them in the header: > > > > +extern void *__vmalloc_array(size_t n, size_t size, gfp_t flags) __alloc_size(1, 2); > > > +extern void *vmalloc_array(size_t n, size_t size) __alloc_size(1, 2); > > > +extern void *__vcalloc(size_t n, size_t size, gfp_t flags) __alloc_size(1, 2); > > > +extern void *vcalloc(size_t n, size_t size) __alloc_size(1, 2); My bad, I have expected __alloc_size before the function name and simply haven't noticed it at the end. -- Michal Hocko SUSE Labs