From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE666C433F5 for ; Mon, 7 Mar 2022 15:48:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36E148D0002; Mon, 7 Mar 2022 10:48:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 31DBC8D0001; Mon, 7 Mar 2022 10:48:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E5058D0002; Mon, 7 Mar 2022 10:48:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0027.hostedemail.com [216.40.44.27]) by kanga.kvack.org (Postfix) with ESMTP id 0C0378D0001 for ; Mon, 7 Mar 2022 10:48:04 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id BE6781828D83E for ; Mon, 7 Mar 2022 15:48:03 +0000 (UTC) X-FDA: 79218021246.17.C620B27 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf21.hostedemail.com (Postfix) with ESMTP id 585B61C000B for ; Mon, 7 Mar 2022 15:48:03 +0000 (UTC) Received: by mail-lf1-f47.google.com with SMTP id w7so13285430lfd.6 for ; Mon, 07 Mar 2022 07:48:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LgEES4/rPa8CVMjAOxZ+enRD8k6L+QVpRqkn7PoSOSU=; b=RSZc176zZ2z6DKzBAW0/0ma/pjDQ2eWWeThHXLuAHZ6NG1gQGBWxhvwoseB0qIHs2I xtwJvLWK3Zvprycj7zHLJJfUxOS0Vo0Apl2CgCbiZT/PXiMhkFAEMpIeCU+rzPDoXfNx qTpt2XqrONNnqoyPxCYe9G4ydQhC8Skt4XznS1sD3gVW/30VXmUCRK48X0ve36+tm3qV 1Lus/aBB0wDJYDvec0+TWFvMi6U8QAqvKJloePoTJkKITaikbNczASLAASzyhAFjLjoO hbv0Ov0PZwCva7hFrYnK9id86QWkC2WzEx+XLhxhXDmC//r2kwXnHXuHPeDw/1LNKP9X Q/ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LgEES4/rPa8CVMjAOxZ+enRD8k6L+QVpRqkn7PoSOSU=; b=y7CtIcCYPIiUOvvYJZ+dnsTbneww5YeVkt4rYApGxm2H8rK67uhbNepDjJssvjz/GH 1fN041Ag3i5EB5ZW6TPhzOQaCA9+isKz1czCwdmXq4yG6A47xJ9yUbhuBEhtidq+vN4t 3gAP9VVtpYY2JT8tNf0m8Uhl7QQSjQVdX9ku081Wp8entlWNN1PMMgba+XI82O2yWINC eh03smSmm6dMl+jXMwprO9PLQdmEWALT24xXRbMNE1aUFShGBcWShbhAfWstNkBs/OJ2 hFNil0XCm93DTaCB3Gl08hQ6c8HC0SMR7eqfiltjP3xyaUpiTlhHLWqMWLFMzIbrO28g m4kw== X-Gm-Message-State: AOAM532WBWOjpDpPGsmgR2gPWixSzXYX4YzayvU+HMl6Jmoyi3fGVaIs 8ajLsGRhWGEe+VmQGLx2vMc= X-Google-Smtp-Source: ABdhPJz5+MA6btAr7UFrQUtyNqVwC20nVSI0t0VnU+K02P5BiAvwNVFHWtOwh+IQ4NSMbkMrvAOaog== X-Received: by 2002:a05:6512:1287:b0:447:5c8a:c9e2 with SMTP id u7-20020a056512128700b004475c8ac9e2mr8227893lfs.64.1646668081667; Mon, 07 Mar 2022 07:48:01 -0800 (PST) Received: from pc638.lan ([155.137.26.201]) by smtp.gmail.com with ESMTPSA id k3-20020a05651239c300b00443c5f9175bsm2909978lfu.46.2022.03.07.07.48.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Mar 2022 07:48:01 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 7 Mar 2022 16:47:59 +0100 To: Bang Li Cc: akpm@linux-foundation.org, urezki@gmail.com, lpf.vector@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/vmalloc: fix comments about vmap_area struct Message-ID: References: <20220305011510.33596-1-libang.linuxer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220305011510.33596-1-libang.linuxer@gmail.com> X-Rspamd-Queue-Id: 585B61C000B X-Stat-Signature: 9ngyf3iefch9gyhqxqxsu4k69qzmmbs7 X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RSZc176z; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=urezki@gmail.com X-Rspamd-Server: rspam03 X-HE-Tag: 1646668083-104086 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Mar 05, 2022 at 09:15:10AM +0800, Bang Li wrote: > the vmap_area_root should be in the "busy" tree and the free_vmap_area_root > should be in the "free" tree. > > Fixes: 688fcbfc06e4 ("mm/vmalloc: modify struct vmap_area to reduce its size") > Signed-off-by: Bang Li > --- > include/linux/vmalloc.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h > index 880227b9f044..05065915edd7 100644 > --- a/include/linux/vmalloc.h > +++ b/include/linux/vmalloc.h > @@ -80,8 +80,8 @@ struct vmap_area { > /* > * The following two variables can be packed, because > * a vmap_area object can be either: > - * 1) in "free" tree (root is vmap_area_root) > - * 2) or "busy" tree (root is free_vmap_area_root) > + * 1) in "free" tree (root is free_vmap_area_root) > + * 2) or "busy" tree (root is vmap_area_root) > */ > union { > unsigned long subtree_max_size; /* in "free" tree */ > -- > 2.25.1 > Agree, those comments were messed up. Reviewed-by: Uladzislau Rezki (Sony) -- Vlad Rezki